netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Andersson Björn" <Bjorn.Andersson@ebc.ericsson.se>
To: netdev@oss.sgi.com
Subject: VLAN patches
Date: Mon, 30 Sep 2002 10:23:44 +0200	[thread overview]
Message-ID: <3D980A10.8B06F2C2@ebc.ericsson.se> (raw)

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

Hi,
I hope you are the right receiver of 8021q-patches.
We are running SuSe 8.0, i.e kernel 2.4.18.

- When addding several egress-mappings we get stuck in an eternal
loop if they end up in the same hash-bucket, see vlan_dev.c.path.

- If we try to remove a vlan with VID 0, ifconfig stops working
completly.
We fixed it with vlan.c.patch.


-- 
* Björn Andersson                   bjorn.andersson@ebc.ericsson.se *
* Ericsson Enterprise AB            NA/EBC/BEES/DNCC                *
* Nacka Strand                      tel: +46-8-422 3512             *
* 13 189 Stockholm, Sweden          fax: +46-8-422 1010             *

[-- Attachment #2: vlan.c.patch --]
[-- Type: text/plain, Size: 342 bytes --]

--- linux-2.4.18.SuSE/net/8021q/vlan.c.orig	Wed Mar 27 13:57:17 2002
+++ linux-2.4.18.SuSE/net/8021q/vlan.c	Wed Sep 18 13:19:13 2002
@@ -207,7 +207,7 @@
 #endif
 
 	/* sanity check */
-	if ((vlan_id >= VLAN_VID_MASK) || (vlan_id <= 0))
+	if ((vlan_id >= VLAN_VID_MASK) || (vlan_id < 0))
 		return -EINVAL;
 
 	spin_lock_bh(&vlan_group_lock);

[-- Attachment #3: vlan_dev.c.patch --]
[-- Type: text/plain, Size: 269 bytes --]

--- linux-2.4.18.SuSE/net/8021q/vlan_dev.c.orig	Wed Mar 27 13:57:17 2002
+++ linux-2.4.18.SuSE/net/8021q/vlan_dev.c	Wed Sep 18 13:19:52 2002
@@ -570,6 +570,7 @@
 					dev_put(dev);
 					return 0;
 				}
+				mp = mp->next;
 			}
 
 			/* Create a new mapping then. */

             reply	other threads:[~2002-09-30  8:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-30  8:23 Andersson Björn [this message]
2002-09-30  8:52 ` [VLAN] VLAN patches Matti Aarnio
2002-09-30 16:02   ` Ben Greear
2002-10-05 19:23 ` Ben Greear
2002-10-06  5:09   ` David S. Miller
2002-10-05 19:27 ` Ben Greear
2002-10-06  4:17   ` David S. Miller
2002-10-06  4:31     ` Ben Greear
2002-10-06  5:05       ` David S. Miller
2002-10-06 22:47         ` jamal
2002-10-07  2:46           ` David S. Miller
2002-10-07  3:35             ` Ben Greear
2002-10-07  5:21               ` David S. Miller
2002-10-07  7:09               ` Eran Mann
2002-10-07  7:06                 ` David S. Miller
2002-10-07  7:32                   ` Eran Mann
2002-10-07 12:05                 ` jamal
2002-10-07 12:09                   ` David S. Miller
2002-10-07 13:01                 ` Boro King
2002-10-12 22:21     ` Boro King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D980A10.8B06F2C2@ebc.ericsson.se \
    --to=bjorn.andersson@ebc.ericsson.se \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).