* RE: [VLAN] VLAN patches
@ 2002-09-30 15:55 Dave Santucci
2002-09-30 16:19 ` Ben Greear
0 siblings, 1 reply; 4+ messages in thread
From: Dave Santucci @ 2002-09-30 15:55 UTC (permalink / raw)
To: vlan, netdev
Bjorn
Since the data type for the vlan_id is specified as an "unsigned short",
The comparison (vlan_id < 0) will always be false due to the range of the data
type.
-ds
-----Original Message-----
From: Andersson Björn [mailto:Bjorn.Andersson@ebc.ericsson.se]
Sent: Monday, September 30, 2002 1:24 AM
To: netdev@oss.sgi.com
Subject: [VLAN] VLAN patches
Hi,
I hope you are the right receiver of 8021q-patches.
We are running SuSe 8.0, i.e kernel 2.4.18.
- When addding several egress-mappings we get stuck in an eternal
loop if they end up in the same hash-bucket, see vlan_dev.c.path.
- If we try to remove a vlan with VID 0, ifconfig stops working
completly.
We fixed it with vlan.c.patch.
--
* Björn Andersson bjorn.andersson@ebc.ericsson.se *
* Ericsson Enterprise AB NA/EBC/BEES/DNCC *
* Nacka Strand tel: +46-8-422 3512 *
* 13 189 Stockholm, Sweden fax: +46-8-422 1010 *
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [VLAN] VLAN patches
2002-09-30 15:55 [VLAN] VLAN patches Dave Santucci
@ 2002-09-30 16:19 ` Ben Greear
0 siblings, 0 replies; 4+ messages in thread
From: Ben Greear @ 2002-09-30 16:19 UTC (permalink / raw)
To: vlan; +Cc: netdev
Dave Santucci wrote:
> Bjorn
> Since the data type for the vlan_id is specified as an "unsigned short",
> The comparison (vlan_id < 0) will always be false due to the range of the data
> type.
>
> -ds
>
>
> -----Original Message-----
> From: Andersson Björn [mailto:Bjorn.Andersson@ebc.ericsson.se]
> Sent: Monday, September 30, 2002 1:24 AM
> To: netdev@oss.sgi.com
> Subject: [VLAN] VLAN patches
>
> Hi,
> I hope you are the right receiver of 8021q-patches.
> We are running SuSe 8.0, i.e kernel 2.4.18.
>
> - When addding several egress-mappings we get stuck in an eternal
> loop if they end up in the same hash-bucket, see vlan_dev.c.path.
>
> - If we try to remove a vlan with VID 0, ifconfig stops working
> completly.
> We fixed it with vlan.c.patch.
Is there any reason to ever let someone add a VLAN of ID 0 in the first place?
Ben
>
>
--
Ben Greear <greearb@candelatech.com> <Ben_Greear AT excite.com>
President of Candela Technologies Inc http://www.candelatech.com
ScryMUD: http://scry.wanfear.com http://scry.wanfear.com/~greear
^ permalink raw reply [flat|nested] 4+ messages in thread
* VLAN patches
@ 2002-09-30 8:23 Andersson Björn
2002-09-30 8:52 ` [VLAN] " Matti Aarnio
0 siblings, 1 reply; 4+ messages in thread
From: Andersson Björn @ 2002-09-30 8:23 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
Hi,
I hope you are the right receiver of 8021q-patches.
We are running SuSe 8.0, i.e kernel 2.4.18.
- When addding several egress-mappings we get stuck in an eternal
loop if they end up in the same hash-bucket, see vlan_dev.c.path.
- If we try to remove a vlan with VID 0, ifconfig stops working
completly.
We fixed it with vlan.c.patch.
--
* Björn Andersson bjorn.andersson@ebc.ericsson.se *
* Ericsson Enterprise AB NA/EBC/BEES/DNCC *
* Nacka Strand tel: +46-8-422 3512 *
* 13 189 Stockholm, Sweden fax: +46-8-422 1010 *
[-- Attachment #2: vlan.c.patch --]
[-- Type: text/plain, Size: 342 bytes --]
--- linux-2.4.18.SuSE/net/8021q/vlan.c.orig Wed Mar 27 13:57:17 2002
+++ linux-2.4.18.SuSE/net/8021q/vlan.c Wed Sep 18 13:19:13 2002
@@ -207,7 +207,7 @@
#endif
/* sanity check */
- if ((vlan_id >= VLAN_VID_MASK) || (vlan_id <= 0))
+ if ((vlan_id >= VLAN_VID_MASK) || (vlan_id < 0))
return -EINVAL;
spin_lock_bh(&vlan_group_lock);
[-- Attachment #3: vlan_dev.c.patch --]
[-- Type: text/plain, Size: 269 bytes --]
--- linux-2.4.18.SuSE/net/8021q/vlan_dev.c.orig Wed Mar 27 13:57:17 2002
+++ linux-2.4.18.SuSE/net/8021q/vlan_dev.c Wed Sep 18 13:19:52 2002
@@ -570,6 +570,7 @@
dev_put(dev);
return 0;
}
+ mp = mp->next;
}
/* Create a new mapping then. */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [VLAN] VLAN patches
2002-09-30 8:23 Andersson Björn
@ 2002-09-30 8:52 ` Matti Aarnio
2002-09-30 16:02 ` Ben Greear
0 siblings, 1 reply; 4+ messages in thread
From: Matti Aarnio @ 2002-09-30 8:52 UTC (permalink / raw)
To: Andersson Björn; +Cc: netdev
On Mon, Sep 30, 2002 at 10:23:44AM +0200, Andersson Björn wrote:
> Hi,
> I hope you are the right receiver of 8021q-patches.
> We are running SuSe 8.0, i.e kernel 2.4.18.
NETDEV isn't right place. I resent your letter to:
vlan@Scry.WANfear.com
(which is strictly posting-by-subscribers-only / others-via-moderator
list...)
> --
> * Björn Andersson bjorn.andersson@ebc.ericsson.se *
/Matti Aarnio
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [VLAN] VLAN patches
2002-09-30 8:52 ` [VLAN] " Matti Aarnio
@ 2002-09-30 16:02 ` Ben Greear
0 siblings, 0 replies; 4+ messages in thread
From: Ben Greear @ 2002-09-30 16:02 UTC (permalink / raw)
To: Matti Aarnio; +Cc: Andersson Björn, netdev
Matti Aarnio wrote:
> On Mon, Sep 30, 2002 at 10:23:44AM +0200, Andersson Björn wrote:
>
>>Hi,
>>I hope you are the right receiver of 8021q-patches.
>>We are running SuSe 8.0, i.e kernel 2.4.18.
>
>
> NETDEV isn't right place. I resent your letter to:
> vlan@Scry.WANfear.com
>
> (which is strictly posting-by-subscribers-only / others-via-moderator
> list...)
It is nice to get VLAN questions and patches to the vlan list, but
I see no reason to restrict patches to that list. Dave is doing a
lot of the VLAN patching and up-keep these days, and I'm not even
sure he reads the vlan list....
So, I personally would be happy to have patches sent to the vlan
list, and cc'd to netdev and/or lkml. Questions about using/configuring
vlans should most likely remain on the vlan mailing list though...
Thanks,
Ben
>
>
>>--
>>* Björn Andersson bjorn.andersson@ebc.ericsson.se *
>
>
> /Matti Aarnio
>
>
--
Ben Greear <greearb@candelatech.com> <Ben_Greear AT excite.com>
President of Candela Technologies Inc http://www.candelatech.com
ScryMUD: http://scry.wanfear.com http://scry.wanfear.com/~greear
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-09-30 16:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-09-30 15:55 [VLAN] VLAN patches Dave Santucci
2002-09-30 16:19 ` Ben Greear
-- strict thread matches above, loose matches on Subject: below --
2002-09-30 8:23 Andersson Björn
2002-09-30 8:52 ` [VLAN] " Matti Aarnio
2002-09-30 16:02 ` Ben Greear
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).