From: Ben Greear <greearb@candelatech.com>
To: "David S. Miller" <davem@redhat.com>
Cc: Bjorn.Andersson@ebc.ericsson.se, netdev@oss.sgi.com
Subject: Re: VLAN patches
Date: Sat, 05 Oct 2002 21:31:45 -0700 [thread overview]
Message-ID: <3D9FBCB1.9080904@candelatech.com> (raw)
In-Reply-To: 20021005.211753.25232925.davem@redhat.com
David S. Miller wrote:
> From: Ben Greear <greearb@candelatech.com>
> Date: Sat, 05 Oct 2002 12:27:15 -0700
>
> This patch looks good too, though the (vlan_id < 0) test
> is redundant since vlan_id is an unsigned number. For
> clarity of code, I wouldn't mind if it stayed in though.
>
> VLAN ID zero is illegal. You should not use ifconfig
> with a VID of zero.
>
As someone mentioned, vlan of 0 may be used to do a priority-only
type of VLAN. I don't know how much this makes sense though...
If we do decide to restrict it, the right place to restrict is in
the creation clause, not the deletion code, as exists now.
--
Ben Greear <greearb@candelatech.com> <Ben_Greear AT excite.com>
President of Candela Technologies Inc http://www.candelatech.com
ScryMUD: http://scry.wanfear.com http://scry.wanfear.com/~greear
next prev parent reply other threads:[~2002-10-06 4:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-30 8:23 VLAN patches Andersson Björn
2002-09-30 8:52 ` [VLAN] " Matti Aarnio
2002-09-30 16:02 ` Ben Greear
2002-10-05 19:23 ` Ben Greear
2002-10-06 5:09 ` David S. Miller
2002-10-05 19:27 ` Ben Greear
2002-10-06 4:17 ` David S. Miller
2002-10-06 4:31 ` Ben Greear [this message]
2002-10-06 5:05 ` David S. Miller
2002-10-06 22:47 ` jamal
2002-10-07 2:46 ` David S. Miller
2002-10-07 3:35 ` Ben Greear
2002-10-07 5:21 ` David S. Miller
2002-10-07 7:09 ` Eran Mann
2002-10-07 7:06 ` David S. Miller
2002-10-07 7:32 ` Eran Mann
2002-10-07 12:05 ` jamal
2002-10-07 12:09 ` David S. Miller
2002-10-07 13:01 ` Boro King
2002-10-12 22:21 ` Boro King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D9FBCB1.9080904@candelatech.com \
--to=greearb@candelatech.com \
--cc=Bjorn.Andersson@ebc.ericsson.se \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).