tulip NAPI patch that works with 2.4.20-pre9 or so?

tulip NAPI patch that works with 2.4.20-pre9 or so?

[Ben Greear]

The latest NAPI tulip patch I could find (tulip-020922.pat)
will not load.  The problem appears that the tulip_misc.c file
no longer exists...

If anyone has a newer patch, I'd love to try it out.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>       <Ben_Greear AT excite.com>
President of Candela Technologies Inc      http://www.candelatech.com
ScryMUD:  http://scry.wanfear.com     http://scry.wanfear.com/~greear

tulip NAPI patch that works with 2.4.20-pre9 or so?

[Robert Olsson]

Ben Greear writes:
 > The latest NAPI tulip patch I could find (tulip-020922.pat)
 > will not load.  The problem appears that the tulip_misc.c file
 > no longer exists...

 :-( I'll look into it.


 > If anyone has a newer patch, I'd love to try it out.
 
Try Jamal's drop-in-replacement
http://www.cyberus.ca/~hadi/patches/tulip-napi.tgz

Cheers.
						--ro

Re: tulip NAPI patch that works with 2.4.20-pre9 or so?

[Ben Greear]

Robert Olsson wrote:
> Ben Greear writes:
>  > The latest NAPI tulip patch I could find (tulip-020922.pat)
>  > will not load.  The problem appears that the tulip_misc.c file
>  > no longer exists...
> 
>  :-( I'll look into it.
> 
> 
>  > If anyone has a newer patch, I'd love to try it out.
>  
> Try Jamal's drop-in-replacement
> http://www.cyberus.ca/~hadi/patches/tulip-napi.tgz

This one froze up after a few seconds on a p430 Phobos 4-port NIC.
(60Mbps on one port, 10Mbps on the others)

However, becker's driver hangs as well, and the 4x5 driver doesn't
even get started...

The driver in 2.4.20-pre9 works pretty good...but I seem to get
rx lockups from time to time...  Still trying to figure out how
to work around that problem...

I'll donate a NIC to a driver hacker if they think that will help
them fix the problem.

Thanks,
Ben

> 
> Cheers.
> 						--ro
> 


-- 
Ben Greear <greearb@candelatech.com>       <Ben_Greear AT excite.com>
President of Candela Technologies Inc      http://www.candelatech.com
ScryMUD:  http://scry.wanfear.com     http://scry.wanfear.com/~greear

Re: tulip NAPI patch that works with 2.4.20-pre9 or so?

[Ben Greear]

Robert Olsson wrote:
> Ben Greear writes:
>  > The latest NAPI tulip patch I could find (tulip-020922.pat)
>  > will not load.  The problem appears that the tulip_misc.c file
>  > no longer exists...
> 
>  :-( I'll look into it.

It works if you fix up the Makefile to not compile tulip_misc.c
and if you change tulip.h to not define EXTRA_STATS.

I'm running it now...initial 5 minutes are a definate improvement
over the in-kernel code....now, if it will only remain stable :)

Ben

-- 
Ben Greear <greearb@candelatech.com>       <Ben_Greear AT excite.com>
President of Candela Technologies Inc      http://www.candelatech.com
ScryMUD:  http://scry.wanfear.com     http://scry.wanfear.com/~greear

Re: tulip NAPI patch that works with 2.4.20-pre9 or so?

[jamal]

Theres a 2419 patch that should work for you at:
http://www.cyberus.ca/~hadi/tulip-2419-napi-nifd.gz

Also pick a small patch on top of this at:
http://www.cyberus.ca/~hadi/patch-napi-tulip-20020915

Now if you wanna get adventorous why not pick:
http://www.cyberus.ca/~hadi/tulip-feed.tgz
You still need that second patch;
In addition to solve your skb problem pick Roberts latest
recycling patch at:
ftp://robur.slu.se/pub/Linux/net-development/skb_recycling/recycle12.pat
The driver i pointed to above has skb-recycling built in.

cheers,
jamal

On Sun, 20 Oct 2002, Ben Greear wrote:

> Robert Olsson wrote:
> > Ben Greear writes:
> >  > The latest NAPI tulip patch I could find (tulip-020922.pat)
> >  > will not load.  The problem appears that the tulip_misc.c file
> >  > no longer exists...
> >
> >  :-( I'll look into it.
>
> It works if you fix up the Makefile to not compile tulip_misc.c
> and if you change tulip.h to not define EXTRA_STATS.
>
> I'm running it now...initial 5 minutes are a definate improvement
> over the in-kernel code....now, if it will only remain stable :)
>
> Ben
>
> --
> Ben Greear <greearb@candelatech.com>       <Ben_Greear AT excite.com>
> President of Candela Technologies Inc      http://www.candelatech.com
> ScryMUD:  http://scry.wanfear.com     http://scry.wanfear.com/~greear
>
>
>

Re: tulip NAPI patch that works with 2.4.20-pre9 or so?

[jamal]

On Mon, 21 Oct 2002, jamal wrote:

>
> Theres a 2419 patch that should work for you at:
> http://www.cyberus.ca/~hadi/tulip-2419-napi-nifd.gz
> Now if you wanna get adventorous why not pick:
> http://www.cyberus.ca/~hadi/tulip-feed.tgz

Make sure you turn off FEEDB in tulip.h (thats new stuff which
hasnt hit the press yet).

cheers,
jamal

Re: tulip NAPI patch that works with 2.4.20-pre9 or so?

[Ben Greear]

jamal wrote:
> Theres a 2419 patch that should work for you at:
> http://www.cyberus.ca/~hadi/tulip-2419-napi-nifd.gz

Link does not work for me.  But I got Robert's patch to
work with a small bit of hacking...  (I changed HZ to 1000
and it locked up 10 seconds after I started (pkts were sent,
but nothing received on any port).  However, I restarted,
and it ran all night with very few dropped packets...)

> Also pick a small patch on top of this at:
> http://www.cyberus.ca/~hadi/patch-napi-tulip-20020915

Does not work either...

> 
> Now if you wanna get adventorous why not pick:
> http://www.cyberus.ca/~hadi/tulip-feed.tgz
> You still need that second patch;

Do you have any descriptions of what this feed patch does differently
from other drivers?

> In addition to solve your skb problem pick Roberts latest
> recycling patch at:
> ftp://robur.slu.se/pub/Linux/net-development/skb_recycling/recycle12.pat
> The driver i pointed to above has skb-recycling built in.

I'll give that a try.

Thanks!

Ben

-- 
Ben Greear <greearb@candelatech.com>       <Ben_Greear AT excite.com>
President of Candela Technologies Inc      http://www.candelatech.com
ScryMUD:  http://scry.wanfear.com     http://scry.wanfear.com/~greear

Re: tulip NAPI patch that works with 2.4.20-pre9 or so?

[jamal]

On Mon, 21 Oct 2002, Ben Greear wrote:

> jamal wrote:
> > Theres a 2419 patch that should work for you at:
> > http://www.cyberus.ca/~hadi/tulip-2419-napi-nifd.gz

Links were wrong, prefix is:
http://www.cyberus.ca/~hadi/patches

> Do you have any descriptions of what this feed patch does differently
> from other drivers?

Id rather not tell you since we are still evaluating its usefullness
and it may not be there next week.

Anyways, i put a patched driver - so you only need to pick the extra
patch:
http://www.cyberus.ca/~hadi/patches/tulip-feed-patched.tgz
this + the core patch from Roberts site.

Make sure you edit tulip.h and edit the number of CPUS you have
to avoid NR_CPU stupidity.

cheers,
jamal

Re: tulip NAPI patch that works with 2.4.20-pre9 or so?

[Ben Greear]

jamal wrote:

> In addition to solve your skb problem pick Roberts latest
> recycling patch at:
> ftp://robur.slu.se/pub/Linux/net-development/skb_recycling/recycle12.pat
> The driver i pointed to above has skb-recycling built in.

Robert, I am porting the existing tulip + your napi patch to support
skb-recycling.  (I realize someone has probably done that, but I
can't find it...Jamal's links are busted!)

In the help file, you suggest this at close:

         for (i=0; i<NR_CPUS; i++) {
                 if(adapter->cnt[i]) {
                         current->state = TASK_INTERRUPTIBLE;
                         schedule_timeout(1);
                 }
         }

I think the second if should probably be while, ie like this:

         for (i=0; i<NR_CPUS; i++) {
                 while(adapter->cnt[i]) {
                         current->state = TASK_INTERRUPTIBLE;
                         schedule_timeout(1);
                 }
         }

Otherwise, you race, and may delete an object that is still in use
somewhere up the stack.

Let me know if I'm nuts!

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>       <Ben_Greear AT excite.com>
President of Candela Technologies Inc      http://www.candelatech.com
ScryMUD:  http://scry.wanfear.com     http://scry.wanfear.com/~greear

Re: tulip NAPI patch that works with 2.4.20-pre9 or so?

[Robert Olsson]

Ben Greear writes:


   In the help file, you suggest this at close:
            for (i=0; i<NR_CPUS; i++) {
 -                  if(adapter->cnt[i]) {
.
   I think the second if should probably be while, ie like this:
            for (i=0; i<NR_CPUS; i++) {
 +                  while(adapter->cnt[i]) {
 
 Thanks!

 Your postings about driver for p430 Phobos 4-port NIC was very confusing. 
 I assume that tulip in 2.4.20-pre9 works even without the tulip-020922.pat.  
 Right?

 Does the board have separate MII-transceivers or is the tulip chips used
 for MII?

 Cheers.

						--ro

Re: tulip NAPI patch that works with 2.4.20-pre9 or so?

[Ben Greear]

Robert Olsson wrote:
> Ben Greear writes:
> 
> 
>    In the help file, you suggest this at close:
>             for (i=0; i<NR_CPUS; i++) {
>  -                  if(adapter->cnt[i]) {
> .
>    I think the second if should probably be while, ie like this:
>             for (i=0; i<NR_CPUS; i++) {
>  +                  while(adapter->cnt[i]) {
>  
>  Thanks!
> 
>  Your postings about driver for p430 Phobos 4-port NIC was very confusing. 
>  I assume that tulip in 2.4.20-pre9 works even without the tulip-020922.pat.  
>  Right?

It works fine as far as negotiation and ping goes, it just drops packets
(and very rarely, locks up on receive) at higher speeds.  With NAPI and
larger receive buffers, it drops very few packets, though it does occasionally
lock up when I first start traffic.  I will run tulip-diag on it next time
it does this...

> 
>  Does the board have separate MII-transceivers or is the tulip chips used
>  for MII?

I'm not sure...

Thanks,
Ben

> 
>  Cheers.
> 
> 						--ro
> 


-- 
Ben Greear <greearb@candelatech.com>       <Ben_Greear AT excite.com>
President of Candela Technologies Inc      http://www.candelatech.com
ScryMUD:  http://scry.wanfear.com     http://scry.wanfear.com/~greear