* [PATCH]: forgotten dev_put for bridge-devices in nf_reinject
@ 2002-12-10 13:35 Patrick McHardy
0 siblings, 0 replies; only message in thread
From: Patrick McHardy @ 2002-12-10 13:35 UTC (permalink / raw)
To: Netfilter Development Mailinglist; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
Hi.
The attached patch releases the bridge devices grabbed in nf_queue after
reinjecting the packet.
Seems someone forgot these (or planned to get Rusty killed) ;)
Bye,
Patrick
[-- Attachment #2: nfqueue-bridge-devput.diff --]
[-- Type: text/plain, Size: 601 bytes --]
--- linux-2.5.50/net/core/netfilter.c.orig 2002-12-10 14:16:20.000000000 +0100
+++ linux-2.5.50/net/core/netfilter.c 2002-12-10 14:19:23.000000000 +0100
@@ -574,7 +574,15 @@
/* Release those devices we held, or Alexey will kill me. */
if (info->indev) dev_put(info->indev);
if (info->outdev) dev_put(info->outdev);
-
+#if defined(CONFIG_BRIDGE) || defined(CONFIG_BRIDGE_MODULE)
+ if (skb->nf_bridge) {
+ if (skb->nf_bridge->physindev)
+ dev_put(skb->nf_bridge->physindev);
+ if (skb->nf_bridge->physoutdev)
+ dev_put(skb->nf_bridge->physoutdev);
+ }
+#endif
+
kfree(info);
return;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2002-12-10 13:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-10 13:35 [PATCH]: forgotten dev_put for bridge-devices in nf_reinject Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).