netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Pete Zaitcev <zaitcev@redhat.com>,
	James Bourne <jbourne@mtroyal.ab.ca>,
	davem@redhat.com, netdev@oss.sgi.com
Subject: NAPI note (was Re: lockups with 2.4.20 (tg3? net/core/dev.c|deliver_to_old_ones))
Date: Fri, 14 Feb 2003 18:58:13 -0500	[thread overview]
Message-ID: <3E4D8295.2050400@pobox.com> (raw)
In-Reply-To: <3E4D66DF.3040800@colorfullife.com>

Manfred Spraul wrote:
> It seems to be a generic NAPI restriction:
> The caller of netif_receive_skb() must not own a spinlock that is 
> acquired from an interrupt handler.


Thanks much for noticing this, Manfred.  tg3 is definitely buggy in this 
regard.  I've CC'd netdev as an FYI...  We should probably patch 
NAPI_HOWTO for this note.

I note that David pointed this out as an area for improvement, so he was 
already thinking in this direction anyway :)

	Jeff

       reply	other threads:[~2003-02-14 23:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3E4D66DF.3040800@colorfullife.com>
2003-02-14 23:58 ` Jeff Garzik [this message]
2003-02-18  2:57   ` NAPI note David S. Miller
2003-02-18 16:31     ` Manfred Spraul
2003-02-19  2:53       ` jamal
2003-02-19  3:14         ` Jeff Garzik
2003-02-19  3:18         ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E4D8295.2050400@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=davem@redhat.com \
    --cc=jbourne@mtroyal.ab.ca \
    --cc=manfred@colorfullife.com \
    --cc=netdev@oss.sgi.com \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).