netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: rask@sygehus.dk
Cc: linux-net@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: Is a driver allowed to modify dev->flags?
Date: Tue, 01 Apr 2003 08:58:06 -0800	[thread overview]
Message-ID: <3E89C51E.1060700@candelatech.com> (raw)
In-Reply-To: <3e89c32348ce76.94538914@not right>

Rask Ingemann Lambertsen wrote:
> Hi.
> 
> Is a network device driver allowed to modify dev->flags? For example:
> 
> if (dev->flags & IFF_ALLMULTI)
>         dev->flags |= IFF_PROMISC;
> 
> I've found it to cause the IFF_PROMISC flag to stick when using "tcpdump -p", which to my surprice sets the IFF_ALLMULTI flag.
> 
> Regards,
> Rask Ingemann Lambertsen
> 
> 

You are supposed to increment the promisc requestors.  I think something like this:

dev_set_promiscuity(dev, 1);



-- 
Ben Greear <greearb@candelatech.com>       <Ben_Greear AT excite.com>
President of Candela Technologies Inc      http://www.candelatech.com
ScryMUD:  http://scry.wanfear.com     http://scry.wanfear.com/~greear



       reply	other threads:[~2003-04-01 16:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3e89c32348ce76.94538914@not right>
2003-04-01 16:58 ` Ben Greear [this message]
2003-04-01 17:26 ` Is a driver allowed to modify dev->flags? Donald Becker
2003-04-01 17:40   ` Rask Ingemann Lambertsen
2003-04-02 13:01 ` Rask Ingemann Lambertsen
2003-04-01 16:49 Rask Ingemann Lambertsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E89C51E.1060700@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=linux-net@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=rask@sygehus.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).