netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Rompf <srompf@isg.de>
To: Scott Feldman <scott.feldman@intel.com>
Cc: Andrew Morton <akpm@digeo.com>, netdev@oss.sgi.com
Subject: Re: e100: "Freeing alive device f7dd8000, eth%d"
Date: Mon, 07 Apr 2003 18:49:31 +0200	[thread overview]
Message-ID: <3E91AC1B.D914760B@isg.de> (raw)
In-Reply-To: Pine.LNX.4.44.0304052219240.5390-100000@localhost.localdomain

Hi,

Scott Feldman wrote:

> This should do the trick, but I'd like to get some testing on it in the QA
> lab before giving thumbs up.

[...]

> +               if(!netif_carrier_ok(bdp->device) && netif_running(bdp->device))

even though this will avoid the problem, I think it is the wrong
solution: Your code is still calling operating system functions on a
netdevice that has not been register_netdevice()d yet. This will invite
problems of all kind.

Cheers, Stefan

  reply	other threads:[~2003-04-07 16:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <C6F5CF431189FA4CBAEC9E7DD5441E010128A28B@orsmsx402.jf.intel.com>
2003-04-06  6:24 ` e100: "Freeing alive device f7dd8000, eth%d" Scott Feldman
2003-04-07 16:49   ` Stefan Rompf [this message]
2003-04-03 10:45 Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E91AC1B.D914760B@isg.de \
    --to=srompf@isg.de \
    --cc=akpm@digeo.com \
    --cc=netdev@oss.sgi.com \
    --cc=scott.feldman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).