[PATCH 2.5.68] sysctl max_dgram_qlen permissions

[PATCH 2.5.68] sysctl max_dgram_qlen permissions

[Nivedita Singhvi]

Currently the sysctl var net.unix.max_dgram_qlen has 
0600 permissions..Need users to be able to read it..
Dont see any reason not to(?).

thanks,
Nivedita

--- sysctl_net_unix.c	Sat Apr 19 19:49:10 2003
+++ sysctl_net_unix.c.new	Fri May  2 13:48:11 2003
@@ -20,7 +20,7 @@
 		.procname	= "max_dgram_qlen",
 		.data		= &sysctl_unix_max_dgram_qlen,
 		.maxlen		= sizeof(int),
-		.mode		= 0600,
+		.mode		= 0644,
 		.proc_handler	= &proc_dointvec
 	},
 	{ .ctl_name = 0 }

Re: [PATCH 2.5.68] sysctl max_dgram_qlen permissions

[David S. Miller]

   From: Nivedita Singhvi <niv@us.ibm.com>
   Date: Fri, 2 May 2003 15:41:06 -0700 (PDT)

   Currently the sysctl var net.unix.max_dgram_qlen has 
   0600 permissions..Need users to be able to read it..
   Dont see any reason not to(?).
   
Applied, thanks.
   
   --- sysctl_net_unix.c	Sat Apr 19 19:49:10 2003
   +++ sysctl_net_unix.c.new	Fri May  2 13:48:11 2003

Please use properly rooted patches in the future.
Ie. soemthing like:

   --- a/linux/net/unix/sysctl_net_unix.c.orig	Sat Apr 19 19:49:10 2003
   +++ b/linux/net/unix/sysctl_net_unix.c	Fri May  2 13:48:11 2003

Patches like yours don't work at all with the automated patch
scripts lots of us use to ease the burdon of applying lots
of patches.

In fact, even if I had changed into net/unix/ before applying
your patch, it would fail because there patch tries to patch
a file named sysctl_net_unix.c.new which of course does not
exist.

Please, this is very lazy and causes me to waste a lot of time fixing
up your patch which I should not have to do. :(

Re: [PATCH 2.5.68] sysctl max_dgram_qlen permissions

[Nivedita Singhvi]

David S. Miller wrote:

> Please, this is very lazy and causes me to waste a lot of time fixing
> up your patch which I should not have to do. :(

Eeep! A thousand pardons Dave! Didnt send you the right
file.  Much flamage deserved and redirected to my sloppiness
and utter inability to correctly recall the name of a file
generated moments earlier...

Much thanks for the cleanup..

Nivedita