From: Jeff Garzik <jgarzik@pobox.com>
To: davej@codemonkey.org.uk
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@oss.sgi.com
Subject: Re: [PATCH] iphase fix.
Date: Thu, 15 May 2003 02:37:17 -0400 [thread overview]
Message-ID: <3EC3359D.5050207@pobox.com> (raw)
In-Reply-To: <200305150417.h4F4HTRA025809@hera.kernel.org>
Linux Kernel Mailing List wrote:
> ChangeSet 1.1127, 2003/05/14 20:44:02-07:00, davej@codemonkey.org.uk
>
> [PATCH] iphase fix.
>
> This went into 2.4 nearly a year back with the wonderfully
> descriptive "Fix from maintainer" comment.
> diff -Nru a/drivers/net/fc/iph5526.c b/drivers/net/fc/iph5526.c
> --- a/drivers/net/fc/iph5526.c Wed May 14 21:17:37 2003
> +++ b/drivers/net/fc/iph5526.c Wed May 14 21:17:37 2003
> @@ -2984,8 +2984,7 @@
> */
> if ((type == ETH_P_ARP) || (status == 0))
> dev_kfree_skb(skb);
> - else
> - netif_wake_queue(dev);
> + netif_wake_queue(dev);
> LEAVE("iph5526_send_packet");
This appears to revert a fix.
You only want to wake the queue if you have room to queue another skb.
Jeff
next parent reply other threads:[~2003-05-15 6:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200305150417.h4F4HTRA025809@hera.kernel.org>
2003-05-15 6:37 ` Jeff Garzik [this message]
2003-05-15 6:43 ` [PATCH] iphase fix Jeff Garzik
2003-05-15 11:32 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EC3359D.5050207@pobox.com \
--to=jgarzik@pobox.com \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).