From: Ben Greear <greearb@candelatech.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Matthew Wilcox <willy@debian.org>,
netdev@oss.sgi.com, "David S. Miller" <davem@redhat.com>,
Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Subject: Re: [PATCH] netdev_ops
Date: Fri, 11 Jul 2003 13:07:07 -0700 [thread overview]
Message-ID: <3F0F18EB.9020609@candelatech.com> (raw)
In-Reply-To: <20030711195856.GB30449@gtf.org>
Jeff Garzik wrote:
> Regardless, addressing your point, I consider ethtool.h a
> kernel-internal header, that's why it uses internal kernel types.
> Anybody who copies it to userspace must deal with that. It is _not_
> intended to be #included directly from userspace. ethtool (the userland
> program) purposefully does its own typedefs and stuff.
Any particular reason to not include it directly? It seems no more
likely to cause problems than to use some potentially out-of-date
copy in user-space. (And it might make the compile slightly tougher
if you are distributing primarily as source.)
Ben
--
Ben Greear <greearb@candelatech.com> <Ben_Greear AT excite.com>
President of Candela Technologies Inc http://www.candelatech.com
ScryMUD: http://scry.wanfear.com http://scry.wanfear.com/~greear
next prev parent reply other threads:[~2003-07-11 20:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-08 16:30 [PATCH] netdev_ops Matthew Wilcox
2003-07-08 20:44 ` Ben Greear
2003-07-08 21:25 ` Matthew Wilcox
2003-07-08 22:08 ` David S. Miller
2003-07-09 16:15 ` Matthew Wilcox
2003-07-09 17:11 ` Ben Greear
2003-07-09 17:25 ` Matthew Wilcox
2003-07-09 18:14 ` Jeff Garzik
2003-07-09 18:24 ` Ben Greear
2003-07-11 19:32 ` Jeff Garzik
2003-07-11 19:51 ` Ben Greear
2003-07-11 19:58 ` Jeff Garzik
2003-07-11 20:07 ` Ben Greear [this message]
2003-07-11 20:04 ` Matthew Wilcox
2003-07-14 5:53 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2003-07-10 7:47 Feldman, Scott
2003-07-10 7:42 ` David S. Miller
2003-07-10 11:21 ` Matthew Wilcox
2003-07-10 13:06 ` Jeff Garzik
2003-07-10 8:18 Feldman, Scott
2003-07-10 20:37 ` David S. Miller
2003-07-11 0:53 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F0F18EB.9020609@candelatech.com \
--to=greearb@candelatech.com \
--cc=acme@conectiva.com.br \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).