Re: [PATCH] ethtool_ops rev 4

[Jeff Garzik <jgarzik@pobox.com>]

David S. Miller wrote:
> On Fri, 01 Aug 2003 19:17:57 -0400
> Jeff Garzik <jgarzik@pobox.com> wrote:
> 
> 
>>Solution #2 chooses to create a tiny bit more 
>>merge-to-mainline pain, but also keeps the mainline kernel drivers more 
>>clean.
> 
> 
> You don't need DO_ETHTOOL_OPS and thus the merge-to-mainline pain
> at all if you do something like:
> 
> 1) SET_ETHDEV_OPS() also overrides the ->do_ioctl() setting to
>    a kcompat_netdev_ioctl() one, but remembers the original pointer
>    somewhere.
> 
> 2) kcompat_netdev_ioctl() does the things DO_ETHTOOL_OPS would
>    have done, failing that it calls the saved ->do_ioctl() pointer.


Certainly.  That's a bit nicer than the back-compat gunk I was plotting, 
even.

Still need the boring and obvious definition of SET_ETHTOOL_OPS in 
mainline, though.

	Jeff