From: David Brownell <david-b@pacbell.net>
To: "David S. Miller" <davem@redhat.com>
Cc: Ben Greear <greearb@candelatech.com>,
jgarzik@pobox.com, scott.feldman@intel.com, netdev@oss.sgi.com
Subject: Re: e100 "Ferguson" release
Date: Sun, 03 Aug 2003 20:09:10 -0700 [thread overview]
Message-ID: <3F2DCE56.6030601@pacbell.net> (raw)
In-Reply-To: <20030803003239.4257ef24.davem@redhat.com>
David S. Miller wrote:
>>Although I have not tried this latest patch, the existing e100 and e1000 in
>>2.4.21 seldom seem to return true to this method: netif_queue_stopped(odev),
>>even when the next hard_start_xmit() call fails.
>
>
> Returning an error from hard_start_xmit() from normal ethernet
> drivers is, frankly, a driver bug and should never happen.
What's "normal" mean?
With the current USB stack, network adapters tend to need
memory allocations there. Those can fail, though it seems
that's not very common. Doesn't seem like a bug, for all
that I'd rather see the those paths be zero-alloc in 2.7.
- Dave
next prev parent reply other threads:[~2003-08-04 3:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-03 4:34 e100 "Ferguson" release Feldman, Scott
2003-08-03 6:06 ` Jeff Garzik
2003-08-03 6:12 ` Jeff Garzik
2003-08-03 7:32 ` Ben Greear
2003-08-03 7:32 ` David S. Miller
2003-08-04 3:09 ` David Brownell [this message]
2003-08-04 3:08 ` David S. Miller
2003-08-04 3:45 ` David Brownell
2003-08-04 3:46 ` David S. Miller
2003-08-04 4:08 ` David Brownell
2003-08-04 4:13 ` David S. Miller
2003-08-04 17:38 ` David Brownell
2003-08-05 8:23 ` Felix Radensky
-- strict thread matches above, loose matches on Subject: below --
2003-08-05 3:45 Feldman, Scott
2003-08-05 5:29 ` Jeff Garzik
2003-08-05 7:16 ` David S. Miller
2003-08-05 14:28 Feldman, Scott
2003-08-05 15:19 Feldman, Scott
2003-08-05 15:24 ` Jeff Garzik
2003-08-10 9:00 ` Felix Radensky
2003-08-05 15:44 ` Felix Radensky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F2DCE56.6030601@pacbell.net \
--to=david-b@pacbell.net \
--cc=davem@redhat.com \
--cc=greearb@candelatech.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=scott.feldman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).