From: Felix Radensky <felix@allot.com>
To: "Feldman, Scott" <scott.feldman@intel.com>
Cc: Ben Greear <greearb@candelatech.com>,
Jeff Garzik <jgarzik@pobox.com>,
netdev@oss.sgi.com
Subject: Re: e100 "Ferguson" release
Date: Tue, 05 Aug 2003 18:44:10 +0300 [thread overview]
Message-ID: <3F2FD0CA.1080403@allot.com> (raw)
In-Reply-To: C6F5CF431189FA4CBAEC9E7DD5441E01022292A4@orsmsx402.jf.intel.com
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
Hi, Scott
This change seems to fix the problem.
Thanks a lot !
Felix.
Feldman, Scott wrote:
>>I've also noticed that the number of hard_start_xmit failures
>>in e1000 has increased significantly in version 5.1.13-k1. In
>>version 5.0.43-k1 the number of failures was much smaller.
>>
>>
>
>Interesting. Felix, would you undo the change[1] below in 5.1.13-k1 and
>see what happens? With the change below, 5.1.13 would be more
>aggressive on Tx cleanup, so we'll be quicker waking the queue than
>before.
>
>-scott
>
> for(i = 0; i < E1000_MAX_INTR; i++)
>- if(!e1000_clean_rx_irq(adapter) &&
>+ if(!e1000_clean_rx_irq(adapter) &
> !e1000_clean_tx_irq(adapter))
> break;
>
>[1] Something still bothers me about this new form where we're mixing a
>bit-wise operator with logical operands. Should this bother me?
>
>
>
[-- Attachment #2: Type: text/html, Size: 1264 bytes --]
next prev parent reply other threads:[~2003-08-05 15:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-05 15:19 e100 "Ferguson" release Feldman, Scott
2003-08-05 15:24 ` Jeff Garzik
2003-08-10 9:00 ` Felix Radensky
2003-08-05 15:44 ` Felix Radensky [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-08-05 14:28 Feldman, Scott
2003-08-05 3:45 Feldman, Scott
2003-08-05 5:29 ` Jeff Garzik
2003-08-05 7:16 ` David S. Miller
2003-08-03 4:34 Feldman, Scott
2003-08-03 6:06 ` Jeff Garzik
2003-08-03 6:12 ` Jeff Garzik
2003-08-03 7:32 ` Ben Greear
2003-08-03 7:32 ` David S. Miller
2003-08-04 3:09 ` David Brownell
2003-08-04 3:08 ` David S. Miller
2003-08-04 3:45 ` David Brownell
2003-08-04 3:46 ` David S. Miller
2003-08-04 4:08 ` David Brownell
2003-08-04 4:13 ` David S. Miller
2003-08-04 17:38 ` David Brownell
2003-08-05 8:23 ` Felix Radensky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F2FD0CA.1080403@allot.com \
--to=felix@allot.com \
--cc=greearb@candelatech.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=scott.feldman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).