From: Ben Greear <greearb@candelatech.com>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: Re: PATCH: Add comment to make finding the priv_flags definition easier.
Date: Wed, 06 Aug 2003 10:30:18 -0700 [thread overview]
Message-ID: <3F313B2A.4080500@candelatech.com> (raw)
In-Reply-To: <20030806034642.4d91641c.davem@redhat.com>
David S. Miller wrote:
> On Tue, 05 Aug 2003 17:24:39 -0700
> Ben Greear <greearb@candelatech.com> wrote:
>
>
>>This helps me, at least, remember where the definitions are at!
>
>
> This is silly, adding one for 'priv_flags' and not one for 'flags'.
>
> I really don't have a taste for these "look in file foo for
> interesting stuff about bar" type comments :-)
Since they are not enums, it is hard to know where they are properly
defined. For someone who is new to the code, I think it helps a great
deal to say where the possible values are defined.
I can add a comment for 'flags' as well, but not if no one cares anyway.
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2003-08-06 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-06 0:24 PATCH: Add comment to make finding the priv_flags definition easier Ben Greear
2003-08-06 10:46 ` David S. Miller
2003-08-06 17:30 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F313B2A.4080500@candelatech.com \
--to=greearb@candelatech.com \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).