* PATCH: Add comment to make finding the priv_flags definition easier.
@ 2003-08-06 0:24 Ben Greear
2003-08-06 10:46 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ben Greear @ 2003-08-06 0:24 UTC (permalink / raw)
To: 'netdev@oss.sgi.com'
This helps me, at least, remember where the definitions are at!
--- linux-2.4.21/include/linux/netdevice.h 2003-06-13 07:51:38.000000000 -0700
+++ linux-2.4.21.amds/include/linux/netdevice.h 2003-07-30 16:27:20.000000000 -0700
@@ -296,7 +296,9 @@
unsigned short flags; /* interface flags (a la BSD) */
unsigned short gflags;
- unsigned short priv_flags; /* Like 'flags' but invisible to userspace. */
+ unsigned short priv_flags; /* Like 'flags' but invisible to userspace,
+ * see: if.h for flag definitions.
+ */
unsigned short unused_alignment_fixer; /* Because we need priv_flags,
* and we want to be 32-bit aligned.
*/
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: Add comment to make finding the priv_flags definition easier.
2003-08-06 0:24 PATCH: Add comment to make finding the priv_flags definition easier Ben Greear
@ 2003-08-06 10:46 ` David S. Miller
2003-08-06 17:30 ` Ben Greear
0 siblings, 1 reply; 3+ messages in thread
From: David S. Miller @ 2003-08-06 10:46 UTC (permalink / raw)
To: Ben Greear; +Cc: netdev
On Tue, 05 Aug 2003 17:24:39 -0700
Ben Greear <greearb@candelatech.com> wrote:
> This helps me, at least, remember where the definitions are at!
This is silly, adding one for 'priv_flags' and not one for 'flags'.
I really don't have a taste for these "look in file foo for
interesting stuff about bar" type comments :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: Add comment to make finding the priv_flags definition easier.
2003-08-06 10:46 ` David S. Miller
@ 2003-08-06 17:30 ` Ben Greear
0 siblings, 0 replies; 3+ messages in thread
From: Ben Greear @ 2003-08-06 17:30 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
David S. Miller wrote:
> On Tue, 05 Aug 2003 17:24:39 -0700
> Ben Greear <greearb@candelatech.com> wrote:
>
>
>>This helps me, at least, remember where the definitions are at!
>
>
> This is silly, adding one for 'priv_flags' and not one for 'flags'.
>
> I really don't have a taste for these "look in file foo for
> interesting stuff about bar" type comments :-)
Since they are not enums, it is hard to know where they are properly
defined. For someone who is new to the code, I think it helps a great
deal to say where the possible values are defined.
I can add a comment for 'flags' as well, but not if no one cares anyway.
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-08-06 17:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-08-06 0:24 PATCH: Add comment to make finding the priv_flags definition easier Ben Greear
2003-08-06 10:46 ` David S. Miller
2003-08-06 17:30 ` Ben Greear
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).