From: Jeff Garzik <jgarzik@pobox.com>
To: Andi Kleen <ak@suse.de>
Cc: netdev@oss.sgi.com
Subject: Re: RFR: new SiS gige driver
Date: Sun, 10 Aug 2003 21:07:31 -0400 [thread overview]
Message-ID: <3F36EC53.8040404@pobox.com> (raw)
In-Reply-To: <20030809152747.GA1618@wotan.suse.de>
Andi Kleen wrote:
> The netif_wake_queue is lost. It's only deadly when clean some packets
> clears the full TX ring, otherwise it will likely recover with the
> next TX finished interrupt but give suboptimal performance.
>
> Fix is to do the my queue is full -> netif_stop_queue inside the spinlock.
"a fix" not "the fix" :)
You can also do what some drivers do, and move the netif_queue_stop
above the queue-packet-to-hw section of driver's ->hard_start_xmit.
Then when this uncommon race occurs, you are guaranteed another
TX-complete interrupt, even if the queue is stopped prematurely.
A lot of drivers netif_stop_queue after, not before, so this is indeed
an issue that needs paying attention to.
Jeff
next prev parent reply other threads:[~2003-08-11 1:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-08 17:39 RFR: new SiS gige driver Jeff Garzik
2003-08-08 19:01 ` Stephen Hemminger
2003-08-09 6:39 ` David S. Miller
2003-08-09 14:15 ` Andi Kleen
2003-08-09 15:01 ` Jeff Garzik
2003-08-09 15:27 ` Andi Kleen
2003-08-11 1:07 ` Jeff Garzik [this message]
2003-08-09 18:10 ` Ben Greear
2003-08-13 18:52 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F36EC53.8040404@pobox.com \
--to=jgarzik@pobox.com \
--cc=ak@suse.de \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).