From: Jeff Garzik <jgarzik@pobox.com>
To: Maillist netdev <netdev@oss.sgi.com>
Cc: "David S. Miller" <davem@redhat.com>
Subject: double-check me?
Date: Sun, 17 Aug 2003 13:45:52 -0400 [thread overview]
Message-ID: <3F3FBF50.8070207@pobox.com> (raw)
Maybe you guys can spot something I'm missing here. alloc_netdev is
supposed to guarantee that dev->priv is aligned by 32 bytes:
struct net_device *alloc_netdev(int sizeof_priv, const char *mask,
void (*setup)(struct net_device *))
{
struct net_device *dev;
int alloc_size;
/* ensure 32-byte alignment of the private area */
alloc_size = sizeof (*dev) + sizeof_priv + 31;
dev = (struct net_device *) kmalloc (alloc_size, GFP_KERNEL);
if (dev == NULL)
{
printk(KERN_ERR "alloc_dev: Unable to allocate device
memory.\n"
);
return NULL;
}
memset(dev, 0, alloc_size);
if (sizeof_priv)
dev->priv = (void *) (((long)(dev + 1) + 31) & ~31);
Now... shouldn't that last line of code be "dev + 1 + sizeof(*dev)" ?
It seems to work 2.[456] for a long time, so I am doubting myself...
surely it would have caused memory corruption or something by now if I
have really found a bug.
Jeff
next reply other threads:[~2003-08-17 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-17 17:45 Jeff Garzik [this message]
2003-08-17 20:58 ` double-check me? Krzysztof Halasa
2003-08-17 22:31 ` Jeff Garzik
2003-08-18 14:38 ` Jason Lunz
2003-08-18 14:41 ` Jeff Garzik
2003-08-17 21:34 ` Jason Lunz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F3FBF50.8070207@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).