* ethtool_features?
@ 2003-08-27 22:22 Jeff Garzik
2003-08-28 6:52 ` ethtool_features? David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Garzik @ 2003-08-27 22:22 UTC (permalink / raw)
To: Maillist netdev; +Cc: davem
Hum. Instead of adding all these _get_foo ops to test dev->features
bits, would anyone mind if I created a single _get_features() ethtool
sub-ioctl?
Given the current ethtool_ops code, its implementation would in fact be
completely transparent to low-level drivers. It need only be
implemented in net/core/ethtool.c, without even adding a new hook.
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ethtool_features?
2003-08-27 22:22 ethtool_features? Jeff Garzik
@ 2003-08-28 6:52 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2003-08-28 6:52 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev
On Wed, 27 Aug 2003 18:22:35 -0400
Jeff Garzik <jgarzik@pobox.com> wrote:
> Hum. Instead of adding all these _get_foo ops to test dev->features
> bits, would anyone mind if I created a single _get_features() ethtool
> sub-ioctl?
I'm personally OK with this _iff_ you add values local
to ethtool for the various feature bits. Ie. don't
export the NETIF_F_* values to userspace.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-08-28 6:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-08-27 22:22 ethtool_features? Jeff Garzik
2003-08-28 6:52 ` ethtool_features? David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).