From: Jeff Garzik <jgarzik@pobox.com>
To: Maillist netdev <netdev@oss.sgi.com>
Subject: The recent free_netdev() conversion...
Date: Mon, 01 Sep 2003 10:59:09 -0400 [thread overview]
Message-ID: <3F535EBD.6090401@pobox.com> (raw)
Note that a lot of error paths were not caught. In the typical driver
you have:
->probe()
dev = alloc_etherdev()
blah_probe()
if blah_probe() fails
goto err_out
register_netdev()
return 0;
err_out:
kfree(dev);
->remove()
free_netdev(dev);
The "kfree" needs to be a free_netdev() too.
Jeff
next reply other threads:[~2003-09-01 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-01 14:59 Jeff Garzik [this message]
2003-09-01 14:53 ` The recent free_netdev() conversion David S. Miller
2003-09-01 15:58 ` Jeff Garzik
2003-09-01 15:58 ` David S. Miller
2003-09-03 22:33 ` [PATCH] 2.6.0-test4-bk5 - Was: " Francois Romieu
2003-09-04 0:56 ` Jeff Garzik
2003-09-04 3:35 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F535EBD.6090401@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).