* Re: [PATCH] (8/8) loopback device simplification
[not found] <20030903164921.7d923008.shemminger@osdl.org>
@ 2003-09-04 0:43 ` Jeff Garzik
2003-09-04 3:41 ` David S. Miller
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2003-09-04 0:43 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: David S. Miller, netdev
Would be nice to move dev_base and dev_base_lock somewhere, maybe
drivers/net/net_init.c (which really should be renamed libnet.c) or
perhaps somewhere in net/*
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] (8/8) loopback device simplification
2003-09-04 0:43 ` [PATCH] (8/8) loopback device simplification Jeff Garzik
@ 2003-09-04 3:41 ` David S. Miller
2003-09-04 19:14 ` Stephen Hemminger
0 siblings, 1 reply; 4+ messages in thread
From: David S. Miller @ 2003-09-04 3:41 UTC (permalink / raw)
To: Jeff Garzik; +Cc: shemminger, netdev
On Wed, 03 Sep 2003 20:43:44 -0400
Jeff Garzik <jgarzik@pobox.com> wrote:
> Would be nice to move dev_base and dev_base_lock somewhere, maybe
> drivers/net/net_init.c (which really should be renamed libnet.c) or
> perhaps somewhere in net/*
Once all of the conversions are done, we can happily move
this someone. My personal preference would be net/core/dev.c,
as I believe we can limit all of the modifications to there
eventually and thus not have to export those two symbols to
the entire kernel any more.
The fact that we export the list and it's locking makes it
really hard to change things.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] (8/8) loopback device simplification
2003-09-04 19:14 ` Stephen Hemminger
@ 2003-09-04 19:07 ` David S. Miller
0 siblings, 0 replies; 4+ messages in thread
From: David S. Miller @ 2003-09-04 19:07 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: jgarzik, netdev
On Thu, 4 Sep 2003 12:14:21 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> On Wed, 3 Sep 2003 20:41:05 -0700
> "David S. Miller" <davem@redhat.com> wrote:
>
> > The fact that we export the list and it's locking makes it
> > really hard to change things.
>
> my current idea is to switch dev_base_lock over to RCU and
> change dev_base to a list macro.
>
> #define for_each_netdev(_d) list_for_each_entry_rcu(_d, &netdev_base, dev_list)
Also see other threads where we were discussing making
it into a hash table in order to speed up search and
name allocation.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] (8/8) loopback device simplification
2003-09-04 3:41 ` David S. Miller
@ 2003-09-04 19:14 ` Stephen Hemminger
2003-09-04 19:07 ` David S. Miller
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2003-09-04 19:14 UTC (permalink / raw)
To: David S. Miller; +Cc: Jeff Garzik, netdev
On Wed, 3 Sep 2003 20:41:05 -0700
"David S. Miller" <davem@redhat.com> wrote:
> On Wed, 03 Sep 2003 20:43:44 -0400
> Jeff Garzik <jgarzik@pobox.com> wrote:
>
> > Would be nice to move dev_base and dev_base_lock somewhere, maybe
> > drivers/net/net_init.c (which really should be renamed libnet.c) or
> > perhaps somewhere in net/*
>
> Once all of the conversions are done, we can happily move
> this someone. My personal preference would be net/core/dev.c,
> as I believe we can limit all of the modifications to there
> eventually and thus not have to export those two symbols to
> the entire kernel any more.
>
> The fact that we export the list and it's locking makes it
> really hard to change things.
my current idea is to switch dev_base_lock over to RCU and
change dev_base to a list macro.
#define for_each_netdev(_d) list_for_each_entry_rcu(_d, &netdev_base, dev_list)
...
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-09-04 19:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20030903164921.7d923008.shemminger@osdl.org>
2003-09-04 0:43 ` [PATCH] (8/8) loopback device simplification Jeff Garzik
2003-09-04 3:41 ` David S. Miller
2003-09-04 19:14 ` Stephen Hemminger
2003-09-04 19:07 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).