From: "Mika Penttilä" <mika.penttila@kolumbus.fi>
To: Julian Anastasov <ja@ssi.bg>
Cc: "David S. Miller" <davem@redhat.com>, netdev@oss.sgi.com
Subject: Re: tunnel xmit and h.raw
Date: Fri, 03 Oct 2003 18:49:27 +0300 [thread overview]
Message-ID: <3F7D9A87.3010005@kolumbus.fi> (raw)
In-Reply-To: <Pine.LNX.4.44.0310031750390.2761-100000@l>
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
If skb is shared skb_realloc_headroom() makes a private head, so no
problem here. Actually the skb_cloned() test seems redundant in this
context.
--Mika
Julian Anastasov wrote:
> Hello,
>
>On Fri, 3 Oct 2003, David S. Miller wrote:
>
>
>
>>> Is the following change needed? May be yes for all kernels
>>>where the nearest skb_shared checks are actual.
>>>
>>>
>>There seems to be no end to these kinds of bugs in the tunnel
>>drivers!
>>
>>Didn't we fix a nearly identical set of bugs in the tunnel
>>drivers just a month or two ago?
>>
>>
>
> The same place, but this one is special: h.raw is updated
>for us on reallocation but if the skb is shared I do not know if this is
>fatal for the other skb users, we change also their h.raw. But I rely
>on your opinion, may be it is safer with this change.
>
>
>
>>I'll review this some more tomorrow and unless I find some problem
>>I'll apply your patch. Thanks a lot.
>>
>>
>
>Regards
>
>--
>Julian Anastasov <ja@ssi.bg>
>
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 1637 bytes --]
next prev parent reply other threads:[~2003-10-03 15:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-03 0:00 tunnel xmit and h.raw Julian Anastasov
2003-10-03 14:30 ` David S. Miller
2003-10-03 14:56 ` Julian Anastasov
2003-10-03 15:04 ` David S. Miller
2003-10-03 15:05 ` David S. Miller
2003-10-03 15:49 ` Mika Penttilä [this message]
2003-10-07 15:32 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F7D9A87.3010005@kolumbus.fi \
--to=mika.penttila@kolumbus.fi \
--cc=davem@redhat.com \
--cc=ja@ssi.bg \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).