From: Dan Kegel <dank@kegel.com>
To: Joe Perches <joe@perches.com>
Cc: David S Miller <davem@redhat.com>,
davem@nuts.ninka.net, linux-net@vger.kernel.org,
netdev@oss.sgi.com
Subject: Re: comment on [NET]: Delete support for old-style protocols, no longer necessary.
Date: Tue, 07 Oct 2003 17:22:34 -0700 [thread overview]
Message-ID: <3F8358CA.1010101@kegel.com> (raw)
In-Reply-To: <1065569620.2340.19.camel@localhost.localdomain>
Joe Perches wrote:
>>>- void *af_packet_priv;
>>>+ struct sock *sk; /* appropriate comment: socket copy? */
>>
>>AF_PACKET is the only user of this private field, and
>>I want people to be aware of this and not try to use it
>>for other stuff.
>>
>>Nobody else can use it for something different, the code
>>in net/core/dev.c does specific things when it's non-NULL
>>knowing that this non-NULL value means that it's an
>>AF_PACKET packet_type being passed to it.
>>
>>So we won't make your suggested change.
>
> Even so, why not call it a struct sock*?
> It is after all and is used as one.
To discourage other modules from using it, and to keep
programmers who aren't working on AF_PACKET from thinking about it.
It's SOP to use opaque cookies when you want to make data private.
- Dan
--
Dan Kegel
http://www.kegel.com
http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045
prev parent reply other threads:[~2003-10-08 0:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-07 18:37 comment on [NET]: Delete support for old-style protocols, no longer necessary Joe Perches
2003-10-07 18:52 ` David S. Miller
2003-10-07 23:33 ` Joe Perches
2003-10-08 0:22 ` Dan Kegel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F8358CA.1010101@kegel.com \
--to=dank@kegel.com \
--cc=davem@nuts.ninka.net \
--cc=davem@redhat.com \
--cc=joe@perches.com \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).