From: Ben Greear <greearb@candelatech.com>
To: Tommy Christensen <tommy.christensen@tpack.net>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] Handle shared SKBs in VLAN receive code
Date: Sat, 11 Oct 2003 12:03:52 -0700 [thread overview]
Message-ID: <3F885418.3090407@candelatech.com> (raw)
In-Reply-To: <3F874A30.6010700@tpack.net>
Tommy Christensen wrote:
> Ben Greear wrote:
>
>>> - if (skb_shared(skb) || skb_cloned(skb)) {
>>> - struct sk_buff *nskb = skb_copy(skb, GFP_ATOMIC);
>>> - kfree(skb);
>>> - skb = nskb;
>>> - }
>>> + skb = skb_unshare(skb, GFP_ATOMIC);
>>
>>
>>
>> On 2.4.22, at least, skb_unshare only checks skb_cloned(), so do we
>> also need to check skb_shared()? Or was that check in the old patch
>> above
>> not needed?
>
>
> skb_shared() is now taken care of by skb_share_check(), called earlier
> in the
> receive routine.
Maybe we should have a method called: skb_get_me_an_skb_that_I_can_modify(skb);
Then the subtle differences between sharing, cloning, etc can be handled
by the skb code internally...
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2003-10-11 19:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-10 23:38 [PATCH] Handle shared SKBs in VLAN receive code Tommy Christensen
2003-10-10 23:52 ` Ben Greear
2003-10-11 0:09 ` Tommy Christensen
2003-10-11 19:03 ` Ben Greear [this message]
2003-10-11 19:03 ` David S. Miller
2003-10-11 19:55 ` Ben Greear
2003-10-11 19:54 ` David S. Miller
2003-10-12 10:00 ` Tommy Christensen
2003-10-13 17:19 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F885418.3090407@candelatech.com \
--to=greearb@candelatech.com \
--cc=netdev@oss.sgi.com \
--cc=tommy.christensen@tpack.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).