netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: netdev@oss.sgi.com
Cc: tommy.christensen@tpack.net
Subject: Re: [PATCH] Handle shared SKBs in VLAN receive code
Date: Sat, 11 Oct 2003 12:55:23 -0700	[thread overview]
Message-ID: <3F88602B.7020603@candelatech.com> (raw)
In-Reply-To: <20031011120339.0da631e6.davem@redhat.com>

David S. Miller wrote:
> On Sat, 11 Oct 2003 12:03:52 -0700
> Ben Greear <greearb@candelatech.com> wrote:
> 
> 
>>Maybe we should have a method called:  skb_get_me_an_skb_that_I_can_modify(skb);
>>
>>Then the subtle differences between sharing, cloning, etc can be handled
>>by the skb code internally...
> 
> 
> We can't create this routine, because it depends upon context.

I have read the sk_buf.h file repeatedly trying to get this all straight
in my head, and I think I'm still missing things.  Is there any other
documentation around that describes in detail exactly the things you must
do to handle shared skbs in all contexts?

I have a question on linearize as well.  Assuming I want to read the IP address
in a packet.  Do I have to linearize before I start looking at offsets in the
skb?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

  reply	other threads:[~2003-10-11 19:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-10 23:38 [PATCH] Handle shared SKBs in VLAN receive code Tommy Christensen
2003-10-10 23:52 ` Ben Greear
2003-10-11  0:09   ` Tommy Christensen
2003-10-11 19:03     ` Ben Greear
2003-10-11 19:03       ` David S. Miller
2003-10-11 19:55         ` Ben Greear [this message]
2003-10-11 19:54           ` David S. Miller
2003-10-12 10:00         ` Tommy Christensen
2003-10-13 17:19           ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F88602B.7020603@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=netdev@oss.sgi.com \
    --cc=tommy.christensen@tpack.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).