* [PATCH] remove dev_get from wanrouter
@ 2003-09-29 21:36 Stephen Hemminger
2003-10-14 17:39 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2003-09-29 21:36 UTC (permalink / raw)
To: Nenad Corbic; +Cc: Jeff Garzik, netdev
The call to dev_get() in wanrouter_device_new_if is racy and redundant and should
be removed. The later 'register_netdev()' does the same test internally and will
return the appropriate error if the name already exists.
This patch is against 2.6.0-test6.
Resend of earlier patch because it was ignored, or missed.
diff -urN -X dontdiff linux-2.5/net/wanrouter/wanmain.c linux-2.5-net/net/wanrouter/wanmain.c
--- linux-2.5/net/wanrouter/wanmain.c 2003-09-22 10:21:35.000000000 -0700
+++ linux-2.5-net/net/wanrouter/wanmain.c 2003-09-22 10:49:29.000000000 -0700
@@ -726,8 +726,6 @@
if (dev->name == NULL) {
err = -EINVAL;
- } else if (dev_get(dev->name)) {
- err = -EEXIST; /* name already exists */
} else {
#ifdef WANDEBUG
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] remove dev_get from wanrouter
2003-09-29 21:36 [PATCH] remove dev_get from wanrouter Stephen Hemminger
@ 2003-10-14 17:39 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2003-10-14 17:39 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Nenad Corbic, netdev
applied to 2.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-10-14 17:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-29 21:36 [PATCH] remove dev_get from wanrouter Stephen Hemminger
2003-10-14 17:39 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).