* [PATCH] Fix 64bit warnings in rtl8139too
@ 2003-10-07 17:56 Andi Kleen
2003-10-14 18:13 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2003-10-07 17:56 UTC (permalink / raw)
To: jgarzik, netdev
Fix a harmless 64bit pointer/integer mismatch warning in 8139too.
diff -u linux-2.5-cleanup/drivers/net/8139too.c-o linux-2.5-cleanup/drivers/net/8139too.c
--- linux-2.5-cleanup/drivers/net/8139too.c-o 2003-09-08 00:02:03.000000000 +0200
+++ linux-2.5-cleanup/drivers/net/8139too.c 2003-12-02 17:13:24.634752560 +0100
@@ -746,7 +746,8 @@
u8 tmp8;
int rc;
unsigned int i;
- u32 pio_start, pio_end, pio_flags, pio_len;
+ unsigned long pio_start;
+ u32 pio_end, pio_flags, pio_len;
unsigned long mmio_start, mmio_end, mmio_flags, mmio_len;
u32 version;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix 64bit warnings in rtl8139too
2003-10-07 17:56 [PATCH] Fix 64bit warnings in rtl8139too Andi Kleen
@ 2003-10-14 18:13 ` Jeff Garzik
2003-10-14 19:49 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2003-10-14 18:13 UTC (permalink / raw)
To: Andi Kleen; +Cc: netdev
Andi Kleen wrote:
> Fix a harmless 64bit pointer/integer mismatch warning in 8139too.
>
> diff -u linux-2.5-cleanup/drivers/net/8139too.c-o linux-2.5-cleanup/drivers/net/8139too.c
> --- linux-2.5-cleanup/drivers/net/8139too.c-o 2003-09-08 00:02:03.000000000 +0200
> +++ linux-2.5-cleanup/drivers/net/8139too.c 2003-12-02 17:13:24.634752560 +0100
> @@ -746,7 +746,8 @@
> u8 tmp8;
> int rc;
> unsigned int i;
> - u32 pio_start, pio_end, pio_flags, pio_len;
> + unsigned long pio_start;
> + u32 pio_end, pio_flags, pio_len;
> unsigned long mmio_start, mmio_end, mmio_flags, mmio_len;
> u32 version;
Why not just make this look like mmio_*?
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix 64bit warnings in rtl8139too
2003-10-14 18:13 ` Jeff Garzik
@ 2003-10-14 19:49 ` Andi Kleen
0 siblings, 0 replies; 3+ messages in thread
From: Andi Kleen @ 2003-10-14 19:49 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Andi Kleen, netdev
On Tue, Oct 14, 2003 at 02:13:04PM -0400, Jeff Garzik wrote:
> Andi Kleen wrote:
> >Fix a harmless 64bit pointer/integer mismatch warning in 8139too.
> >
> >diff -u linux-2.5-cleanup/drivers/net/8139too.c-o
> >linux-2.5-cleanup/drivers/net/8139too.c
> >--- linux-2.5-cleanup/drivers/net/8139too.c-o 2003-09-08
> >00:02:03.000000000 +0200
> >+++ linux-2.5-cleanup/drivers/net/8139too.c 2003-12-02
> >17:13:24.634752560 +0100
> >@@ -746,7 +746,8 @@
> > u8 tmp8;
> > int rc;
> > unsigned int i;
> >- u32 pio_start, pio_end, pio_flags, pio_len;
> >+ unsigned long pio_start;
> >+ u32 pio_end, pio_flags, pio_len;
> > unsigned long mmio_start, mmio_end, mmio_flags, mmio_len;
> > u32 version;
>
>
> Why not just make this look like mmio_*?
No problems, feel free to do that.
I just did the minimal change to fix the warning.
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-10-14 19:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-10-07 17:56 [PATCH] Fix 64bit warnings in rtl8139too Andi Kleen
2003-10-14 18:13 ` Jeff Garzik
2003-10-14 19:49 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).