netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ihar 'Philips' Filipau" <filia@softhome.net>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: netdev@oss.sgi.com
Subject: net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags
Date: Mon, 10 Nov 2003 12:10:46 +0100	[thread overview]
Message-ID: <3FAF7236.7020209@softhome.net> (raw)

Hi!

    [ I'm trying to cc: netdev - but they are not that welcome - and 
require subscription. I'm way too lazy (and my mail box is not that 
fast) to subscribe to send simple typo - if this is a case at all. ]

    [ kernel v2.6.0-test7 as found on lxr.linux.no, 2.4.{18,22} has the 
same - but line numbers are different. ]

    On line 1057 we have: "msg->msg_flags|=MSG_TRUNC;" to indicate that 
message was truncated.

    But on line 1073, where we make return status to user, we check 
against user suplied flags, but NOT msg->msg_flags.

    It looks like obvious typo.

-- 
Ihar 'Philips' Filipau  / with best regards from Saarbruecken.
--                                                           _ _ _
  "... and for $64000 question, could you get yourself       |_|*|_|
    vaguely familiar with the notion of on-topic posting?"   |_|_|*|
                                 -- Al Viro @ LKML           |*|*|*|

             reply	other threads:[~2003-11-10 11:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-10 11:10 Ihar 'Philips' Filipau [this message]
2003-11-11  7:12 ` net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FAF7236.7020209@softhome.net \
    --to=filia@softhome.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).