From: John Partridge <johnip@sgi.com>
To: "David S. Miller" <davem@redhat.com>
Cc: ak@suse.de, netdev@oss.sgi.com, jgarzik@pobox.com, jes@sgi.com,
David Mosberger <davidm@hpl.hp.com>
Subject: Re: Tigon3 5701 PCI-X recv performance problem
Date: Tue, 11 Nov 2003 15:39:49 -0600 [thread overview]
Message-ID: <3FB15725.4050705@sgi.com> (raw)
In-Reply-To: <20031111122403.2d7bcf28.davem@redhat.com>
David S. Miller wrote:
> Why are you depending upon MCKINLEY? Don't all ia64 cpus
> give traps for unaligned memory accesses?
>
> That is what this CONFIG option tells the whole kernel.
OK, I made it ALL IA64, but I only know for sure about Itanium2's
--- linux/drivers/net/tg3.c 2003-11-10 18:28:10.000000000 -0600
+++ patch/drivers/net/tg3.c 2003-11-10 18:58:35.000000000 -0600
@@ -2257,7 +2257,11 @@
len = ((desc->idx_len & RXD_LEN_MASK) >> RXD_LEN_SHIFT) - 4; /* omit crc */
- if (len > RX_COPY_THRESHOLD) {
+ if (len > RX_COPY_THRESHOLD
+#if defined(CONFIG_UNALIGNED_EXPENSIVE)
+ && tp->rx_offset == 2
+#endif
+ ) {
int skb_size;
skb_size = tg3_alloc_rx_skb(tp, opaque_key,
--- linux/arch/ia64/Kconfig 2003-10-25 13:44:46.000000000 -0500
+++ patch/arch/ia64/Kconfig 2003-11-11 15:37:58.000000000 -0600
@@ -468,6 +468,11 @@
agent" (/sbin/hotplug) to load modules and set up software needed
to use devices as you hotplug them.
+config CONFIG_UNALIGNED_EXPENSIVE
+ bool "Use kernel aligned buffers"
+ depends on IA64
+ default y
+
source "drivers/pci/hotplug/Kconfig"
source "drivers/pcmcia/Kconfig"
--
John Partridge
Silicon Graphics Inc
Tel: 651-683-3428
Vnet: 233-3428
E-Mail: johnip@sgi.com
next prev parent reply other threads:[~2003-11-11 21:39 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 17:12 Tigon3 5701 PCI-X recv performance problem John Partridge
2003-10-08 17:10 ` David S. Miller
2003-10-08 17:52 ` John Partridge
2003-10-08 18:26 ` David S. Miller
2003-10-08 19:02 ` John Partridge
2003-10-08 19:11 ` Steve Modica
2003-10-08 19:15 ` David S. Miller
2003-10-08 18:21 ` Steve Modica
2003-10-08 18:29 ` David S. Miller
2003-10-08 18:37 ` Andi Kleen
2003-10-08 19:22 ` David S. Miller
2003-10-08 20:22 ` Andi Kleen
2003-10-08 20:24 ` David S. Miller
2003-10-08 20:33 ` Andi Kleen
2003-10-08 20:32 ` David S. Miller
2003-10-08 20:46 ` Andi Kleen
2003-10-08 20:50 ` David S. Miller
2003-10-10 19:05 ` Steve Modica
2003-10-10 19:20 ` Andi Kleen
2003-10-11 13:17 ` Steve Modica
2003-10-11 13:19 ` Andi Kleen
2003-10-11 17:50 ` David S. Miller
2003-10-13 19:53 ` John Partridge
2003-10-13 19:51 ` David S. Miller
2003-10-14 16:49 ` John Partridge
2003-10-14 16:53 ` David S. Miller
2003-11-11 1:24 ` John Partridge
2003-11-11 2:29 ` David S. Miller
2003-11-11 20:04 ` John Partridge
2003-11-11 20:24 ` David S. Miller
2003-11-11 21:26 ` John Partridge
2003-11-11 21:32 ` Jeff Garzik
2003-12-03 22:11 ` John Partridge
2003-11-11 21:39 ` John Partridge [this message]
2003-11-11 23:09 ` David S. Miller
2003-11-11 23:53 ` Andi Kleen
2003-11-12 1:46 ` John Partridge
2003-11-12 6:19 ` Andi Kleen
2003-11-12 7:05 ` Jeff Garzik
2003-11-12 15:32 ` John Partridge
2003-11-12 15:43 ` Christoph Hellwig
2003-11-11 20:25 ` David S. Miller
2003-11-11 20:57 ` Jeff Garzik
2003-10-14 18:47 ` John Partridge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FB15725.4050705@sgi.com \
--to=johnip@sgi.com \
--cc=ak@suse.de \
--cc=davem@redhat.com \
--cc=davidm@hpl.hp.com \
--cc=jes@sgi.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).