netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] de4x5 - missing free on error path
@ 2003-11-13  0:30 Stephen Hemminger
  2003-11-13  1:40 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2003-11-13  0:30 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: netdev

NE54-de4x5 - fix missing free on error path - found by viro

diff -Nru a/drivers/net/tulip/de4x5.c b/drivers/net/tulip/de4x5.c
--- a/drivers/net/tulip/de4x5.c	Tue Nov 11 14:15:07 2003
+++ b/drivers/net/tulip/de4x5.c	Tue Nov 11 14:15:07 2003
@@ -1237,6 +1237,8 @@
 	if (lp->useSROM) {
 	    lp->state = INITIALISED;
 	    if (srom_infoleaf_info(dev)) {
+	        dma_free_coherent (gendev, lp->dma_size,
+			       lp->rx_ring, lp->dma_rings);
 		return -ENXIO;
 	    }
 	    srom_init(dev);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] de4x5 - missing free on error path
  2003-11-13  0:30 [PATCH] de4x5 - missing free on error path Stephen Hemminger
@ 2003-11-13  1:40 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2003-11-13  1:40 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev

applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-11-13  1:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-11-13  0:30 [PATCH] de4x5 - missing free on error path Stephen Hemminger
2003-11-13  1:40 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).