From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: "David S. Miller" <davem@redhat.com>, netdev@oss.sgi.com
Subject: Re: [PATCH]: Adjust qlen when grafting in multiple qdiscs
Date: Mon, 17 Nov 2003 15:40:32 +0100 [thread overview]
Message-ID: <3FB8DDE0.1070105@trash.net> (raw)
In-Reply-To: <1069076786.1075.19.camel@jzny.localdomain>
Hi Jamal,
I've tested tbf and prio changes before and after. Unfortunately I've
never used dsmark so I didn't test this part. I did try to make sure
my changes make sense, and I still don't see why this wouldn't be
correct. dsmark increments sch->q.qlen in enqueue, so it needs to
adjust it in dsmark_graft if the old queue is non-empty. If this is
wrong, please enlighten me so I can fix my patch.
Best regards,
Patrick
jamal wrote:
>Did you test some of this stuff or just did a mass-edit? I havent paid
>attention to all the details, but what would decrementing sch->q.qlen on
>grafting mean on a dsmark?
>
>cheers,
>jamal
>
>
>
next prev parent reply other threads:[~2003-11-17 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-13 14:47 [PATCH]: Adjust qlen when grafting in multiple qdiscs Patrick McHardy
2003-11-17 14:22 ` jamal
2003-11-17 14:40 ` Patrick McHardy [this message]
2003-11-17 14:59 ` jamal
2003-11-17 16:13 ` Patrick McHardy
2003-11-17 17:30 ` jamal
2003-11-17 18:15 ` Patrick McHardy
2003-11-17 19:25 ` jamal
2003-11-17 19:38 ` Werner Almesberger
2003-11-17 21:10 ` Patrick McHardy
2003-11-18 0:34 ` [UPDATED PATCH]: " Patrick McHardy
2003-11-19 1:19 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FB8DDE0.1070105@trash.net \
--to=kaber@trash.net \
--cc=davem@redhat.com \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).