netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: "'netdev@oss.sgi.com'" <netdev@oss.sgi.com>
Subject: RFC:  Enabling ethernet drivers to return FCS in the skb?
Date: Mon, 17 Nov 2003 13:52:17 -0800	[thread overview]
Message-ID: <3FB94311.10004@candelatech.com> (raw)

Ethereal now has the ability to decode (and check) the FCS for ethernet
frames (assuming it understands the protocol so it can determine that the last
4 bytes are FCS).

Is there any interest in adding an Ethtool command to tell the driver to
push the extra 4 bytes of CSUM into the skb?

When enabling this feature, I'd also like to allow drivers to receive
frames with bad FCS as well.  This could be a separate flag if desired,
but if only good FCS will ever be passed up the stack, then having it in
the skb does not really add new information.  At least some hardware appears
to support receiving bad FCS frames (e1000, evidently), but I am not sure
how wide-spread this feature is...

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

             reply	other threads:[~2003-11-17 21:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-17 21:52 Ben Greear [this message]
2003-11-19 11:35 ` RFC: Enabling ethernet drivers to return FCS in the skb? Rask Ingemann Lambertsen
2003-11-19 13:20   ` Maciej W. Rozycki
2003-11-19 15:33   ` Ben Greear
2003-11-20 16:34     ` Rask Ingemann Lambertsen
2003-11-23  9:02       ` Ben Greear
2003-11-24  0:05         ` Rask Ingemann Lambertsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FB94311.10004@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).