From: Jeff Garzik <jgarzik@pobox.com>
To: Brad House <brad_mssw@gentoo.org>
Cc: netdev@oss.sgi.com
Subject: r8169 and tg3
Date: Mon, 17 Nov 2003 23:39:19 -0500 [thread overview]
Message-ID: <3FB9A277.70309@pobox.com> (raw)
In-Reply-To: <47973.68.105.173.45.1069042089.squirrel@mail.mainstreetsoftworks.com>
Brad House wrote:
> The current in-kernel version of the r8169 driver is v1.2
> from RealTek. This is a patch against 2.6.0-test9-bk6
> and later kernels that updates the driver to 1.6 from RealTek.
> Just small patches applied to it to port to 2.6 kernel, etc.
> It works with the 8110S chip found on many motherboards,
> especially x86_64 mobos.
A bit of history... SiS sent me a driver for their gigabit chip,
SIS190 (sis190.c). Full of PCI DMA bugs, alignment problems, and fun
like that. After taking flak for merging it :) I fixed all those bugs.
Fast forward a bit, I find out that sis190.c was copied from r8169.c,
and modified a bit to work with SiS chips. I look at r8169.c, and find
all those same bugs -- and the RealTek updates don't address any of that.
So, what needs to happen is somebody needs to look at the sis190 changes
that went in, and apply those same fixes to r8169.
Two tangents, while I have your attention:
1) If you have problems with the tg3 driver, we need to get those bug
reports and fix them. bcm5700 is not going to be merged into the
kernel. Further, there was at least one serious x86-64 issue that was
fixed in tg3, and we need to make sure users are testing that driver,
not a non-standard driver with bugs of its own.
2) Please CC me on all net driver patches, since I am the dude that
actually puts those patches into the kernel.
Thanks,
Jeff
next prev parent reply other threads:[~2003-11-18 4:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-17 4:08 [PATCH 2.6.0-test9-bk6] r8169.c update for 8110S support from RTL 1.6 version Brad House
2003-11-18 4:39 ` Jeff Garzik [this message]
2003-11-18 4:51 ` r8169 and tg3 Brad House
2003-11-18 10:00 ` Jan Oravec
2003-11-18 11:01 ` David S. Miller
2003-11-18 12:58 ` Francois Romieu
2003-11-19 17:24 ` Jeff Garzik
2003-11-19 18:44 ` Robert Olsson
2003-11-20 0:00 ` [patches] 2.6.0-test9 - r8169 DMA API conversion Francois Romieu
2003-11-20 0:08 ` Brad House
2003-11-20 0:45 ` Francois Romieu
2003-11-20 0:59 ` Brad House
2003-11-20 1:34 ` Andre Tomt
2003-11-20 1:35 ` Brad House
2003-11-20 1:36 ` Brad House
2003-11-20 1:36 ` Jeff Garzik
2003-11-21 0:36 ` Francois Romieu
2003-11-21 1:38 ` Jeff Garzik
2003-11-21 23:20 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FB9A277.70309@pobox.com \
--to=jgarzik@pobox.com \
--cc=brad_mssw@gentoo.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).