* [PATCH ] more RTL-8139 clone boards
@ 2003-11-18 19:46 Xose Vazquez Perez
2003-11-19 17:14 ` Jeff Garzik
2003-11-19 17:27 ` Stephen Hemminger
0 siblings, 2 replies; 6+ messages in thread
From: Xose Vazquez Perez @ 2003-11-18 19:46 UTC (permalink / raw)
To: netdev, jgarzik
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
0x018A 0x0106 LevelOne FPC-0106TX
0x126C 0x1211 Nortel Networks 10/100BaseTX
0x1743 0x8139 Peppercon AG ROL-F
0x021B 0x8139 Compaq HNE-300
--
HTML mails are going to trash automagically
[-- Attachment #2: 8139too_idents.diff --]
[-- Type: text/plain, Size: 678 bytes --]
--- linux/drivers/net/8139too.c 2003-11-15 16:47:54.000000000 +0100
+++ new/drivers/net/8139too.c 2003-11-18 20:31:49.000000000 +0100
@@ -250,6 +250,10 @@
{0x11db, 0x1234, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
{0x1432, 0x9130, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
{0x02ac, 0x1012, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
+ {0x018a, 0x0106, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
+ {0x126c, 0x1211, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
+ {0x1743, 0x8139, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
+ {0x021b, 0x8139, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
#ifdef CONFIG_SH_SECUREEDGE5410
/* Bogus 8139 silicon reports 8129 without external PROM :-( */
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH ] more RTL-8139 clone boards
2003-11-18 19:46 [PATCH ] more RTL-8139 clone boards Xose Vazquez Perez
@ 2003-11-19 17:14 ` Jeff Garzik
2003-11-19 17:27 ` Stephen Hemminger
1 sibling, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2003-11-19 17:14 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: netdev
applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH ] more RTL-8139 clone boards
2003-11-18 19:46 [PATCH ] more RTL-8139 clone boards Xose Vazquez Perez
2003-11-19 17:14 ` Jeff Garzik
@ 2003-11-19 17:27 ` Stephen Hemminger
2003-11-19 17:37 ` Jeff Garzik
1 sibling, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2003-11-19 17:27 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: netdev, jgarzik
On Tue, 18 Nov 2003 20:46:34 +0100
Xose Vazquez Perez <xose@wanadoo.es> wrote:
>
> 0x018A 0x0106 LevelOne FPC-0106TX
> 0x126C 0x1211 Nortel Networks 10/100BaseTX
> 0x1743 0x8139 Peppercon AG ROL-F
> 0x021B 0x8139 Compaq HNE-300
Maybe time to start using pci_ids.h?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH ] more RTL-8139 clone boards
2003-11-19 17:27 ` Stephen Hemminger
@ 2003-11-19 17:37 ` Jeff Garzik
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2003-11-19 17:37 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Xose Vazquez Perez, netdev
Stephen Hemminger wrote:
> On Tue, 18 Nov 2003 20:46:34 +0100
> Xose Vazquez Perez <xose@wanadoo.es> wrote:
>
>
>>0x018A 0x0106 LevelOne FPC-0106TX
>>0x126C 0x1211 Nortel Networks 10/100BaseTX
>>0x1743 0x8139 Peppercon AG ROL-F
>>0x021B 0x8139 Compaq HNE-300
>
>
> Maybe time to start using pci_ids.h?
This is mainly a matter of opinion. My opinion: no. ;-)
I think it's rather silly to keep adding to pci_ids.h, when the ids are
just arbitrary hex numbers with no useful value. I certainly support
mnemonic constants when they have value... but if the _only_ place a PCI
id constant exists is (a) in a pci_device_id list and (b) in pci_ids.h,
then it seems rather wasteful rather than helpful.
IMO, the constants just bloat the pci_device_id list, whereas the ones
with hex numbers are nice, single lines.
As an aside, include/linux/pci_ids.h is a heavily patched file, and
conflicts occur all the time.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH ] more RTL-8139 clone boards
@ 2004-02-22 15:26 Xose Vazquez Perez
2004-02-26 5:48 ` Jeff Garzik
0 siblings, 1 reply; 6+ messages in thread
From: Xose Vazquez Perez @ 2004-02-22 15:26 UTC (permalink / raw)
To: netdev, jgarzik, marcelo.tosatti
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
This patch already is in 2.6.
0x018A 0x0106 LevelOne FPC-0106TX
0x126C 0x1211 Nortel Networks 10/100BaseTX
0x1743 0x8139 Peppercon AG ROL-F
0x021B 0x8139 Compaq HNE-300
[-- Attachment #2: 8139too_idents.diff --]
[-- Type: text/plain, Size: 674 bytes --]
--- linux/drivers/net/8139too.c 2004-02-05 23:00:12.000000000 +0100
+++ n/drivers/net/8139too.c 2004-02-22 16:23:27.000000000 +0100
@@ -255,6 +255,10 @@
{0x11db, 0x1234, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
{0x1432, 0x9130, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
{0x02ac, 0x1012, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
+ {0x018a, 0x0106, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
+ {0x126c, 0x1211, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
+ {0x1743, 0x8139, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
+ {0x021b, 0x8139, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
#ifdef CONFIG_SH_SECUREEDGE5410
/* Bogus 8139 silicon reports 8129 without external PROM :-( */
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH ] more RTL-8139 clone boards
2004-02-22 15:26 Xose Vazquez Perez
@ 2004-02-26 5:48 ` Jeff Garzik
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2004-02-26 5:48 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: netdev, marcelo.tosatti
applied to 2.4
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-02-26 5:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-11-18 19:46 [PATCH ] more RTL-8139 clone boards Xose Vazquez Perez
2003-11-19 17:14 ` Jeff Garzik
2003-11-19 17:27 ` Stephen Hemminger
2003-11-19 17:37 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2004-02-22 15:26 Xose Vazquez Perez
2004-02-26 5:48 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).