netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	netdev@oss.sgi.com, Jes Sorensen <jes@wildopensource.com>
Subject: Re: [PATCH] 8139too NAPI for net-drivers-2.5-exp
Date: Wed, 19 Nov 2003 12:16:21 -0500	[thread overview]
Message-ID: <3FBBA565.3090206@pobox.com> (raw)
In-Reply-To: <20031118161730.2690cb76.shemminger@osdl.org>

Stephen Hemminger wrote:
> Here is the 8139too version in net-drivers-2.5-exp modified for NAPI.
> Also:
> 	64k receive ring - has to handle wrap for that case;
> 	   the NoWrap flag does nothing if using this big ring.
> 	assert() -> BUG_ON()
> 	
> To deal with the races with tx_timeout, put back in the rx_lock from earlier versions.


Applied with a "but"...  This patch still contains some errors WRT 8139 
hardware and the RX path.  But I'm comfortable with nailing those 
problems down during public testing of net-drivers-2.5-exp.

Hirofumi, Stephen, and others, please test, particularly packet floods 
with (a) tiny packets and (b) huge packets.  Ditto Jes, if you've still 
got hardware, and are interested in DoS fixes in 8139too.

	Jeff

  reply	other threads:[~2003-11-19 17:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-19  0:17 [PATCH] 8139too NAPI for net-drivers-2.5-exp Stephen Hemminger
2003-11-19 17:16 ` Jeff Garzik [this message]
2003-11-19 19:02   ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FBBA565.3090206@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=jes@wildopensource.com \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).