From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "Feldman, Scott" <scott.feldman@intel.com>, netdev@oss.sgi.com
Subject: Re: e100 in net-drivers-2.5-exp
Date: Tue, 16 Dec 2003 17:36:20 -0500 [thread overview]
Message-ID: <3FDF88E4.1060002@pobox.com> (raw)
In-Reply-To: <20031216104326.70809423.shemminger@osdl.org>
[-- Attachment #1: Type: text/plain, Size: 573 bytes --]
Stephen Hemminger wrote:
> e100 in net-drivers-2.5-exp won't compile as a module.
>
> Don't think the new module_param() works the way it is being used
> in the new e100 driver.
>
> CC [M] drivers/net/e100.o
> drivers/net/e100.c:170: error: parse error before "int"
> drivers/net/e100.c:170: warning: type defaults to `int' in declaration of `module_param'
> drivers/net/e100.c:170: warning: function declaration isn't a prototype
> drivers/net/e100.c:170: warning: data definition has no type or storage class
Thanks, just checked in the attached patch to fix this.
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 338 bytes --]
===== drivers/net/e100.c 1.2 vs edited =====
--- 1.2/drivers/net/e100.c Tue Dec 9 15:38:42 2003
+++ edited/drivers/net/e100.c Tue Dec 16 17:35:12 2003
@@ -136,6 +136,7 @@
#include <linux/config.h>
#include <linux/module.h>
+#include <linux/moduleparam.h>
#include <linux/kernel.h>
#include <linux/types.h>
#include <linux/slab.h>
prev parent reply other threads:[~2003-12-16 22:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-16 18:43 e100 in net-drivers-2.5-exp Stephen Hemminger
2003-12-16 22:36 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FDF88E4.1060002@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=scott.feldman@intel.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).