netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [e1000 2.6-exp] back out CSA interrupt fix
@ 2004-01-05  0:43 Feldman, Scott
  2004-01-06  7:53 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Feldman, Scott @ 2004-01-05  0:43 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: netdev, Feldman, Scott, cramerj


* 8086:1019 82547 CSA-based LOMs lock up the system with
  this code, so let's revert back to what's in 2.6.0 until
  we can figure out why this is causing problems.

---------

--- net-drivers-2.5-exp/drivers/net/e1000/e1000_main.c.orig	2004-01-04 15:58:59.000000000 -0800
+++ net-drivers-2.5-exp/drivers/net/e1000/e1000_main.c	2004-01-04 15:59:32.000000000 -0800
@@ -2097,26 +2097,10 @@
 		__netif_rx_schedule(netdev);
 	}
 #else
-        /* Writing IMC and IMS is needed for 82547.
-	   Due to Hub Link bus being occupied, an interrupt 
-	   de-assertion message is not able to be sent. 
-	   When an interrupt assertion message is generated later,
-	   two messages are re-ordered and sent out.
-	   That causes APIC to think 82547 is in de-assertion
-	   state, while 82547 is in assertion state, resulting 
-	   in dead lock. Writing IMC forces 82547 into 
-	   de-assertion state.
-        */
-	if(hw->mac_type == e1000_82547 || hw->mac_type == e1000_82547_rev_2)
-		e1000_irq_disable(adapter);
-
 	for(i = 0; i < E1000_MAX_INTR; i++)
 		if(!e1000_clean_rx_irq(adapter) &
 		   !e1000_clean_tx_irq(adapter))
 			break;
-
-	if(hw->mac_type == e1000_82547 || hw->mac_type == e1000_82547_rev_2)
-		e1000_irq_enable(adapter);
 #endif
 
 	return IRQ_HANDLED;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [e1000 2.6-exp] back out CSA interrupt fix
  2004-01-05  0:43 [e1000 2.6-exp] back out CSA interrupt fix Feldman, Scott
@ 2004-01-06  7:53 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2004-01-06  7:53 UTC (permalink / raw)
  To: Feldman, Scott; +Cc: netdev, cramerj

applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-01-06  7:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-05  0:43 [e1000 2.6-exp] back out CSA interrupt fix Feldman, Scott
2004-01-06  7:53 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).