From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Greear Subject: Re: [PATCH] ath10k: htt_rx: Fix signedness bug in ath10k_update_per_peer_tx_stats Date: Fri, 5 Oct 2018 12:09:50 -0700 Message-ID: <3a55bec6-d20d-f500-e741-b228a86b7117@candelatech.com> References: <20181005184245.GA11700@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: "Gustavo A. R. Silva" , Kalle Valo , "David S. Miller" Return-path: In-Reply-To: <20181005184245.GA11700@embeddedor.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 10/05/2018 11:42 AM, Gustavo A. R. Silva wrote: > Currently, the error handling for the call to function > ath10k_get_legacy_rate_idx() doesn't work because > *rate_idx* is of type u8 (8 bits, unsigned), which > makes it impossible for it to hold a value less > than 0. > > Fix this by changing the type of variable *rate_idx* > to s8 (8 bits, signed). There are more than 127 rates, are you sure this is doing what you want? Thanks, Ben > > Addresses-Coverity-ID: 1473914 ("Unsigned compared against 0") > Fixes: 0189dbd71cbd ("ath10k: get the legacy rate index to update the txrate table") > Signed-off-by: Gustavo A. R. Silva > --- > drivers/net/wireless/ath/ath10k/htt_rx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c > index f240525..edd0e74 100644 > --- a/drivers/net/wireless/ath/ath10k/htt_rx.c > +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c > @@ -2753,7 +2753,8 @@ ath10k_update_per_peer_tx_stats(struct ath10k *ar, > struct ath10k_per_peer_tx_stats *peer_stats) > { > struct ath10k_sta *arsta = (struct ath10k_sta *)sta->drv_priv; > - u8 rate = 0, rate_idx = 0, sgi; > + u8 rate = 0, sgi; > + s8 rate_idx = 0; > struct rate_info txrate; > > lockdep_assert_held(&ar->data_lock); > -- Ben Greear Candela Technologies Inc http://www.candelatech.com