* [PATCH][net-next] nfp: flower: use GFP_KERNEL in idr_preload
@ 2026-02-05 5:59 lirongqing
2026-02-05 7:48 ` 答复: " Li,Rongqing
0 siblings, 1 reply; 2+ messages in thread
From: lirongqing @ 2026-02-05 5:59 UTC (permalink / raw)
To: Jakub Kicinski, Simon Horman, Andrew Lunn, David S . Miller,
Eric Dumazet, Paolo Abeni, Li RongQing, oss-drivers, netdev,
linux-kernel
From: Li RongQing <lirongqing@baidu.com>
idr_preload() is called in a sleepable context before acquiring a
spinlock. Change the allocation flag from GFP_ATOMIC to GFP_KERNEL
to allow direct reclaim and improve allocation success rate under
memory pressure.
Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
drivers/net/ethernet/netronome/nfp/flower/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c b/drivers/net/ethernet/netronome/nfp/flower/main.c
index 83eaa5a..8f232c6 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/main.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/main.c
@@ -63,7 +63,7 @@ nfp_flower_get_internal_port_id(struct nfp_app *app, struct net_device *netdev)
if (id > 0)
return id;
- idr_preload(GFP_ATOMIC);
+ idr_preload(GFP_KERNEL);
spin_lock_bh(&priv->internal_ports.lock);
id = idr_alloc(&priv->internal_ports.port_ids, netdev,
NFP_MIN_INT_PORT_ID, NFP_MAX_INT_PORT_ID, GFP_ATOMIC);
--
2.9.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* 答复: [PATCH][net-next] nfp: flower: use GFP_KERNEL in idr_preload
2026-02-05 5:59 [PATCH][net-next] nfp: flower: use GFP_KERNEL in idr_preload lirongqing
@ 2026-02-05 7:48 ` Li,Rongqing
0 siblings, 0 replies; 2+ messages in thread
From: Li,Rongqing @ 2026-02-05 7:48 UTC (permalink / raw)
To: Jakub Kicinski, Simon Horman, Andrew Lunn, David S . Miller,
Eric Dumazet, Paolo Abeni, oss-drivers@corigine.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
>
> From: Li RongQing <lirongqing@baidu.com>
>
> idr_preload() is called in a sleepable context before acquiring a spinlock. Change
> the allocation flag from GFP_ATOMIC to GFP_KERNEL to allow direct reclaim
> and improve allocation success rate under memory pressure.
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
> drivers/net/ethernet/netronome/nfp/flower/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c
> b/drivers/net/ethernet/netronome/nfp/flower/main.c
> index 83eaa5a..8f232c6 100644
> --- a/drivers/net/ethernet/netronome/nfp/flower/main.c
> +++ b/drivers/net/ethernet/netronome/nfp/flower/main.c
> @@ -63,7 +63,7 @@ nfp_flower_get_internal_port_id(struct nfp_app *app,
> struct net_device *netdev)
> if (id > 0)
> return id;
>
> - idr_preload(GFP_ATOMIC);
> + idr_preload(GFP_KERNEL);
> spin_lock_bh(&priv->internal_ports.lock);
> id = idr_alloc(&priv->internal_ports.port_ids, netdev,
> NFP_MIN_INT_PORT_ID, NFP_MAX_INT_PORT_ID,
> GFP_ATOMIC);
> --
> 2.9.4
Sorry, please drop this patch,;
nfp_flower_get_internal_port_id() maybe be called in system_highpri_wq workqueue, so GFP_ATOMIC is right
[Li,Rongqing]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-05 7:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-05 5:59 [PATCH][net-next] nfp: flower: use GFP_KERNEL in idr_preload lirongqing
2026-02-05 7:48 ` 答复: " Li,Rongqing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox