From: Nathan Fontenot <nfont@linux.vnet.ibm.com>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: netdev@vger.kernel.org, jallen@linux.vnet.ibm.com,
tlfalcon@linux.vnet.ibm.com
Subject: Re: [PATCH] ibmvnic: Remove skb->protocol checks in ibmvnic_xmit
Date: Fri, 9 Feb 2018 13:33:41 -0600 [thread overview]
Message-ID: <3a6e3b31-2af6-4736-033e-abec38e591ab@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180209113203.2608d3f9@cakuba.netronome.com>
On 02/09/2018 01:32 PM, Jakub Kicinski wrote:
> On Fri, 09 Feb 2018 13:09:34 -0600, Nathan Fontenot wrote:
>> From: John Allen (jallen@linux.vnet.ibm.com>
>
> Nit: s/(/</
>
>> Having these checks in ibmvnic_xmit causes problems with VLAN
>> tagging and balance-alb/tlb bonding modes. The restriction they
>> imposed can be removed.
>>
>> Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
>
> Patch does not have author's SoB line, the kernel bots will complain
> about this, so please add it if it's not a problem.
>
Oops. Thanks for pointing this out, I'll re-send.
-Nathan
prev parent reply other threads:[~2018-02-09 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 19:09 [PATCH] ibmvnic: Remove skb->protocol checks in ibmvnic_xmit Nathan Fontenot
2018-02-09 19:32 ` Jakub Kicinski
2018-02-09 19:33 ` Nathan Fontenot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a6e3b31-2af6-4736-033e-abec38e591ab@linux.vnet.ibm.com \
--to=nfont@linux.vnet.ibm.com \
--cc=jallen@linux.vnet.ibm.com \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).