From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathan Fontenot Subject: Re: [PATCH] ibmvnic: Remove skb->protocol checks in ibmvnic_xmit Date: Fri, 9 Feb 2018 13:33:41 -0600 Message-ID: <3a6e3b31-2af6-4736-033e-abec38e591ab@linux.vnet.ibm.com> References: <151820337461.54278.5008284319777707694.stgit@ltcalpine2-lp14.aus.stglabs.ibm.com> <20180209113203.2608d3f9@cakuba.netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jallen@linux.vnet.ibm.com, tlfalcon@linux.vnet.ibm.com To: Jakub Kicinski Return-path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48186 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752501AbeBITdr (ORCPT ); Fri, 9 Feb 2018 14:33:47 -0500 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w19JXfo4011000 for ; Fri, 9 Feb 2018 14:33:46 -0500 Received: from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154]) by mx0a-001b2d01.pphosted.com with ESMTP id 2g1fqx52wv-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 09 Feb 2018 14:33:46 -0500 Received: from localhost by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 9 Feb 2018 12:33:45 -0700 In-Reply-To: <20180209113203.2608d3f9@cakuba.netronome.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 02/09/2018 01:32 PM, Jakub Kicinski wrote: > On Fri, 09 Feb 2018 13:09:34 -0600, Nathan Fontenot wrote: >> From: John Allen (jallen@linux.vnet.ibm.com> > > Nit: s/(/ >> Having these checks in ibmvnic_xmit causes problems with VLAN >> tagging and balance-alb/tlb bonding modes. The restriction they >> imposed can be removed. >> >> Signed-off-by: Nathan Fontenot > > Patch does not have author's SoB line, the kernel bots will complain > about this, so please add it if it's not a problem. > Oops. Thanks for pointing this out, I'll re-send. -Nathan