* [PATCH] ibmvnic: Remove skb->protocol checks in ibmvnic_xmit
@ 2018-02-09 19:09 Nathan Fontenot
2018-02-09 19:32 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Nathan Fontenot @ 2018-02-09 19:09 UTC (permalink / raw)
To: netdev; +Cc: jallen, tlfalcon
From: John Allen (jallen@linux.vnet.ibm.com>
Having these checks in ibmvnic_xmit causes problems with VLAN
tagging and balance-alb/tlb bonding modes. The restriction they
imposed can be removed.
Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
---
drivers/net/ethernet/ibm/ibmvnic.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 5caaa9033841..f276c6dcb4a9 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -1414,10 +1414,7 @@ static int ibmvnic_xmit(struct sk_buff *skb, struct net_device *netdev)
hdrs += 2;
}
/* determine if l2/3/4 headers are sent to firmware */
- if ((*hdrs >> 7) & 1 &&
- (skb->protocol == htons(ETH_P_IP) ||
- skb->protocol == htons(ETH_P_IPV6) ||
- skb->protocol == htons(ETH_P_ARP))) {
+ if ((*hdrs >> 7) & 1) {
build_hdr_descs_arr(tx_buff, &num_entries, *hdrs);
tx_crq.v1.n_crq_elem = num_entries;
tx_buff->indir_arr[0] = tx_crq;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ibmvnic: Remove skb->protocol checks in ibmvnic_xmit
2018-02-09 19:09 [PATCH] ibmvnic: Remove skb->protocol checks in ibmvnic_xmit Nathan Fontenot
@ 2018-02-09 19:32 ` Jakub Kicinski
2018-02-09 19:33 ` Nathan Fontenot
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2018-02-09 19:32 UTC (permalink / raw)
To: Nathan Fontenot; +Cc: netdev, jallen, tlfalcon
On Fri, 09 Feb 2018 13:09:34 -0600, Nathan Fontenot wrote:
> From: John Allen (jallen@linux.vnet.ibm.com>
Nit: s/(/</
> Having these checks in ibmvnic_xmit causes problems with VLAN
> tagging and balance-alb/tlb bonding modes. The restriction they
> imposed can be removed.
>
> Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Patch does not have author's SoB line, the kernel bots will complain
about this, so please add it if it's not a problem.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ibmvnic: Remove skb->protocol checks in ibmvnic_xmit
2018-02-09 19:32 ` Jakub Kicinski
@ 2018-02-09 19:33 ` Nathan Fontenot
0 siblings, 0 replies; 3+ messages in thread
From: Nathan Fontenot @ 2018-02-09 19:33 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: netdev, jallen, tlfalcon
On 02/09/2018 01:32 PM, Jakub Kicinski wrote:
> On Fri, 09 Feb 2018 13:09:34 -0600, Nathan Fontenot wrote:
>> From: John Allen (jallen@linux.vnet.ibm.com>
>
> Nit: s/(/</
>
>> Having these checks in ibmvnic_xmit causes problems with VLAN
>> tagging and balance-alb/tlb bonding modes. The restriction they
>> imposed can be removed.
>>
>> Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
>
> Patch does not have author's SoB line, the kernel bots will complain
> about this, so please add it if it's not a problem.
>
Oops. Thanks for pointing this out, I'll re-send.
-Nathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-09 19:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-09 19:09 [PATCH] ibmvnic: Remove skb->protocol checks in ibmvnic_xmit Nathan Fontenot
2018-02-09 19:32 ` Jakub Kicinski
2018-02-09 19:33 ` Nathan Fontenot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).