From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH iproute2] libnetlink: Handle extack messages for non-error
 case
Date: Tue, 7 Nov 2017 13:39:56 +0900
Message-ID: <3a849a1f-8073-2650-cdfa-200346010cd2@gmail.com>
References: <1510027932-28546-1-git-send-email-dsahern@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: stephen@networkplumber.org, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f51.google.com ([74.125.83.51]:53526 "EHLO
        mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751503AbdKGEkA (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 6 Nov 2017 23:40:00 -0500
Received: by mail-pg0-f51.google.com with SMTP id s2so10047602pge.10
        for <netdev@vger.kernel.org>; Mon, 06 Nov 2017 20:40:00 -0800 (PST)
In-Reply-To: <1510027932-28546-1-git-send-email-dsahern@gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 11/7/17 1:12 PM, David Ahern wrote:
> @@ -101,15 +101,18 @@ static int nl_dump_ext_err(const struct nlmsghdr *nlh, nl_ext_ack_fn_t errfn)
>  	}
>  
>  	if (errfn)
> -		return errfn(errmsg, off, err_nlh);
> +		return errfn(msg, off, err_nlh);
>  
> -	if (errmsg && *errmsg != '\0') {
> -		fprintf(stderr, "Error: %s", errmsg);
> -		if (errmsg[strlen(errmsg) - 1] != '.')
> +	if (msg && *msg != '\0') {
> +		bool is_err = (nlh->nlmsg_type == NLMSG_ERROR);

Forgot to update that to:
	bool is_err = !!err->error


Please ignore this one; will re-send a v2 later.