Netdev List
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com,
	andrii@kernel.org, memxor@gmail.com, bpf@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH net 0/3] Fix broken TC_ACT_REDIRECT from qdiscs
Date: Tue, 30 Jun 2026 17:09:04 +0200	[thread overview]
Message-ID: <3a88dd85-6857-462f-98cd-9cd5dac25316@iogearbox.net> (raw)
In-Reply-To: <20260630143730.ZhXWjEIh@linutronix.de>

On 6/30/26 4:37 PM, Sebastian Andrzej Siewior wrote:
> On 2026-06-30 14:33:28 [+0200], Daniel Borkmann wrote:
>> This is an alternative fix to [0] in order to not uglify
>> __dev_queue_xmit() with sprinkled ifdefs given this can be
>> simplified and isolated through a simple test into the BPF
>> redirect helper itself.
>>
>> I've also added a proper BPF selftest, so there is no need
>> to check-in a binary BPF object into selftests given we do
>> have BPF infra for all of this.
> 
> 1/3 makes sense. Assuming we wouldn't have this per-task memory
> assignment, wouldn't then the state from one redirect leak into another?

For the normal/functional case out of tcx / cls_bpf via clsact
not given skb_do_redirect() is called right after return. (For
the full qdisc case it was never working in the first place.)

> For what it's worth:
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> 
> Sebastian


      reply	other threads:[~2026-06-30 15:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 12:33 [PATCH net 0/3] Fix broken TC_ACT_REDIRECT from qdiscs Daniel Borkmann
2026-06-30 12:33 ` [PATCH net 1/3] bpf: Reject redirect helpers without a bpf_net_context Daniel Borkmann
2026-06-30 12:33 ` [PATCH net 2/3] net/sched: Handle TC_ACT_REDIRECT from qdisc filter chains Daniel Borkmann
2026-06-30 15:16   ` Jamal Hadi Salim
2026-06-30 15:23     ` Daniel Borkmann
2026-07-01 15:35       ` Jamal Hadi Salim
2026-06-30 12:33 ` [PATCH net 3/3] selftests/bpf: Add test for redirect from qdisc qevent block Daniel Borkmann
2026-06-30 14:37 ` [PATCH net 0/3] Fix broken TC_ACT_REDIRECT from qdiscs Sebastian Andrzej Siewior
2026-06-30 15:09   ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a88dd85-6857-462f-98cd-9cd5dac25316@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=andrii@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=jhs@mojatatu.com \
    --cc=kuba@kernel.org \
    --cc=memxor@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox