Re: [PATCH net v2] net/sched: act_gact: properly init 'goto chain'

[Davide Caratti <dcaratti@redhat.com>]

hello Cong and Jamal,

On Fri, 2018-10-19 at 13:40 -0700, Cong Wang wrote:
> On Thu, Oct 18, 2018 at 8:30 AM Davide Caratti <dcaratti@redhat.com> wrote:
> > The alternative is, we systematically forbid usage of 'goto chain' in
> > tcfg_paction, so that:
> > 
> > # tc f a dev v0 egress matchall action <whatever> random determ goto chain 4 5
> > 
> > is systematically rejected with -EINVAL. This comand never worked, so we
> > are not breaking anything in userspace.

> This is exactly why I asked you if we really need to support it. :)
> 
> If no one finds it useful, disallowing it is a good solution here, as
> we don't need
> to introduce any additional code to handle filter chains.

On Thu, 2018-10-18 at 08:52 -0400, Jamal Hadi Salim wrote:

> Rejection is a good solution[1].
> Would be helpful to set an ext_ack to something like
> "only one goto chain is supported currently"

OK to forbid 'goto chain' on fallback actions for gact and police: I just
sent out a small series for that, feedbacks are welcome.

@David: this patch is no more needed, it can be dropped from patchwork.

thanks!
regards,
-- 
davide