From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39FA0C43381 for ; Sun, 17 Feb 2019 11:58:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 060662195D for ; Sun, 17 Feb 2019 11:58:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727389AbfBQL6u (ORCPT ); Sun, 17 Feb 2019 06:58:50 -0500 Received: from smtprelay0114.hostedemail.com ([216.40.44.114]:39839 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725795AbfBQL6u (ORCPT ); Sun, 17 Feb 2019 06:58:50 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id B7B21180A887B; Sun, 17 Feb 2019 11:58:48 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: paint10_6993029f9610e X-Filterd-Recvd-Size: 2533 Received: from XPS-9350 (unknown [172.58.27.41]) (Authenticated sender: joe@perches.com) by omf17.hostedemail.com (Postfix) with ESMTPA; Sun, 17 Feb 2019 11:58:44 +0000 (UTC) Message-ID: <3aa310cede544d76e53ec962676a6ea4e3bd6b23.camel@perches.com> Subject: Re: [PATCH v2 net-next 2/2] net: sock: undefine SOCK_DEBUGGING From: Joe Perches To: Yafang Shao , davem@davemloft.net Cc: daniel@iogearbox.net, edumazet@google.com, xiyou.wangcong@gmail.com, netdev@vger.kernel.org, shaoyafang@didiglobal.com Date: Sun, 17 Feb 2019 03:58:42 -0800 In-Reply-To: <1550334537-380-3-git-send-email-laoar.shao@gmail.com> References: <1550334537-380-1-git-send-email-laoar.shao@gmail.com> <1550334537-380-3-git-send-email-laoar.shao@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 2019-02-17 at 00:28 +0800, Yafang Shao wrote: > SOCK_DEBUG() is a old facility for debugging. > If the user want to use it for debugging, the user must modify the > application first, that doesn't seem like a good way. > Now we have more powerful facilities, i.e. bpf or tracepoint, for this kind > of debugging purpose. > So we'd better disable it by default. > The reason why I don't remove it comepletely is that someone may still > would like to use it for debugging. > > Signed-off-by: Yafang Shao > Suggested-by: Joe Perches > --- > include/net/sock.h | 13 ++++++++----- > net/core/sock.c | 3 +++ > 2 files changed, 11 insertions(+), 5 deletions(-) > > diff --git a/include/net/sock.h b/include/net/sock.h > index 6679f3c..d41e8f4 100644 > --- a/include/net/sock.h > +++ b/include/net/sock.h > @@ -81,14 +81,17 @@ > */ > > /* Define this to get the SOCK_DBG debugging facility. */ > -#define SOCK_DEBUGGING > +/* #define SOCK_DEBUGGING */ > #ifdef SOCK_DEBUGGING > -#define SOCK_DEBUG(sk, msg...) do { if ((sk) && sock_flag((sk), SOCK_DBG)) \ > - printk(KERN_DEBUG msg); } while (0) > +#define SOCK_DEBUG(sk, fmt, ...) \ > +do { \ > + if ((sk) && sock_flag((sk), SOCK_DBG)) \ > + pr_debug(fmt, ##__VA_ARGS__); \ trivia: I would not suggest pr_debug here as it also requires either DEBUG to be defined or CONFIG_DYNAMIC_DEBUG to be set. If you really set SOCK_DEBUGGING, then printk(KERN_DEBUG is probably right.