From: David Laight <David.Laight@ACULAB.COM>
To: 'Andrew Lunn' <andrew@lunn.ch>, Brian Masney <bmasney@redhat.com>
Cc: "irusskikh@marvell.com" <irusskikh@marvell.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cth451@gmail.com" <cth451@gmail.com>
Subject: RE: [PATCH] net: atlantic: fix check for invalid ethernet addresses
Date: Wed, 30 Nov 2022 23:12:15 +0000 [thread overview]
Message-ID: <3adb7dc622a3429782ca89e83c8e020d@AcuMS.aculab.com> (raw)
In-Reply-To: <Y4fMBl6sv+SUyt9Z@lunn.ch>
From: Andrew Lunn
> Sent: 30 November 2022 21:33
...
> > That won't work for this board since that function only checks that the
> > MAC "is not 00:00:00:00:00:00, is not a multicast address, and is not
> > FF:FF:FF:FF:FF:FF." The MAC address that we get on all of our boards is
> > 00:17:b6:00:00:00.
>
> Which is a valid MAC address. So i don't see why the kernel should
> reject it and use a random one.
It isn't very valid...
The first three bytes are the mulicast, local and company bits.
So the last three bytes being zero indicate you have the
very first address the company allocated.
Pretty much zero chance of that board ever working well
enough to be in a system.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-11-30 23:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 17:42 [PATCH] net: atlantic: fix check for invalid ethernet addresses Brian Masney
2022-11-30 17:57 ` Brian Masney
2022-11-30 18:26 ` Tianhao Chai
2022-11-30 18:47 ` Brian Masney
2022-11-30 19:41 ` Andrew Lunn
2022-11-30 21:08 ` Brian Masney
2022-11-30 21:32 ` Andrew Lunn
2022-11-30 23:12 ` David Laight [this message]
2022-12-01 2:22 ` Andrew Lunn
2022-12-01 8:07 ` [EXT] " Igor Russkikh
2022-12-01 13:55 ` Brian Masney
2022-12-01 14:14 ` Andrew Lunn
2022-12-01 15:18 ` Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3adb7dc622a3429782ca89e83c8e020d@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=andrew@lunn.ch \
--cc=bmasney@redhat.com \
--cc=cth451@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).