From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy Date: Fri, 26 Oct 2018 09:48:25 -0600 Message-ID: <3afc552f-2f76-4555-31af-ffeb4a2fb9ff@gmail.com> References: <20181024153249.15374-1-dsahern@kernel.org> <1305358874.1795395.1540553653206@mail.libero.it> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org To: Marco Berizzi , David Ahern Return-path: Received: from mail-pg1-f195.google.com ([209.85.215.195]:35179 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726113AbeJ0A0C (ORCPT ); Fri, 26 Oct 2018 20:26:02 -0400 Received: by mail-pg1-f195.google.com with SMTP id 32-v6so735654pgu.2 for ; Fri, 26 Oct 2018 08:48:28 -0700 (PDT) In-Reply-To: <1305358874.1795395.1540553653206@mail.libero.it> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/26/18 5:34 AM, Marco Berizzi wrote: > Apologies for bothering you again. > I applied your patch to 4.19, but after issuing this > command: > > root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1 > root@Calimero:~# ping 10.81.104.1 > PING 10.81.104.1 (10.81.104.1) 56(84) bytes of data. > ^C > --- 10.81.104.1 ping statistics --- > 2 packets transmitted, 0 received, 100% packet loss, time 1001ms > > I'm losing ipv4 connectivity. > If I remove the qdisc everything is going to work again: > > root@Calimero:~# tc qdisc del dev eth0 root > root@Calimero:~# ping 10.81.104.1 > PING 10.81.104.1 (10.81.104.1) 56(84) bytes of data. > 64 bytes from 10.81.104.1: icmp_seq=1 ttl=255 time=0.711 ms > ^C > --- 10.81.104.1 ping statistics --- > 1 packets transmitted, 1 received, 0% packet loss, time 0ms > rtt min/avg/max/mdev = 0.711/0.711/0.711/0.000 ms > I backed up to 95278ddaa15cfa23e4a06ee9ed7b6ee0197c500b which is the commit before the validation patch and it does not work there. Can you bisect and find out when it stopped working?