From: Thor Thayer <thor.thayer@linux.intel.com>
To: Dalon Westergreen <dwesterg@gmail.com>,
netdev@vger.kernel.org, dinguyen@kernel.org
Cc: Dalon Westergreen <dalon.westergreen@intel.com>
Subject: Re: [PATCH net-next 3/8] net: eth: altera: tse: fix altera_dmaops declaration
Date: Thu, 15 Nov 2018 17:10:20 -0600 [thread overview]
Message-ID: <3b5267bb-ca63-6dc3-39c6-e06cf4ad1daf@linux.intel.com> (raw)
In-Reply-To: <20181115005047.28464-4-dwesterg@gmail.com>
On 11/14/18 6:50 PM, Dalon Westergreen wrote:
> From: Dalon Westergreen <dalon.westergreen@intel.com>
>
> The declaration of struct altera_dmaops does not have
> identifier names. Add identifier names to confrom with
> required coding styles.
>
> Signed-off-by: Dalon Westergreen <dalon.westergreen@intel.com>
> ---
> drivers/net/ethernet/altera/altera_tse.h | 30 +++++++++++++-----------
> 1 file changed, 16 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/net/ethernet/altera/altera_tse.h b/drivers/net/ethernet/altera/altera_tse.h
> index e2feee87180a..d5b97e02e6d6 100644
> --- a/drivers/net/ethernet/altera/altera_tse.h
> +++ b/drivers/net/ethernet/altera/altera_tse.h
> @@ -396,20 +396,22 @@ struct altera_tse_private;
> struct altera_dmaops {
> int altera_dtype;
> int dmamask;
> - void (*reset_dma)(struct altera_tse_private *);
> - void (*enable_txirq)(struct altera_tse_private *);
> - void (*enable_rxirq)(struct altera_tse_private *);
> - void (*disable_txirq)(struct altera_tse_private *);
> - void (*disable_rxirq)(struct altera_tse_private *);
> - void (*clear_txirq)(struct altera_tse_private *);
> - void (*clear_rxirq)(struct altera_tse_private *);
> - int (*tx_buffer)(struct altera_tse_private *, struct tse_buffer *);
> - u32 (*tx_completions)(struct altera_tse_private *);
> - void (*add_rx_desc)(struct altera_tse_private *, struct tse_buffer *);
> - u32 (*get_rx_status)(struct altera_tse_private *);
> - int (*init_dma)(struct altera_tse_private *);
> - void (*uninit_dma)(struct altera_tse_private *);
> - void (*start_rxdma)(struct altera_tse_private *);
> + void (*reset_dma)(struct altera_tse_private *priv);
> + void (*enable_txirq)(struct altera_tse_private *priv);
> + void (*enable_rxirq)(struct altera_tse_private *priv);
> + void (*disable_txirq)(struct altera_tse_private *priv);
> + void (*disable_rxirq)(struct altera_tse_private *priv);
> + void (*clear_txirq)(struct altera_tse_private *priv);
> + void (*clear_rxirq)(struct altera_tse_private *priv);
> + int (*tx_buffer)(struct altera_tse_private *priv,
> + struct tse_buffer *buffer);
> + u32 (*tx_completions)(struct altera_tse_private *priv);
> + void (*add_rx_desc)(struct altera_tse_private *priv,
> + struct tse_buffer *buffer);
> + u32 (*get_rx_status)(struct altera_tse_private *priv);
> + int (*init_dma)(struct altera_tse_private *priv);
> + void (*uninit_dma)(struct altera_tse_private *priv);
> + void (*start_rxdma)(struct altera_tse_private *priv);
> };
>
> /* This structure is private to each device.
>
Acked-by: Thor Thayer <thor.thayer@linux.intel.com>
next prev parent reply other threads:[~2018-11-16 9:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 0:50 [PATCH net-next 0/8] net: eth: altera: tse: Add PTP and mSGDMA prefetcher Dalon Westergreen
2018-11-15 0:50 ` [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx_buffer call response Dalon Westergreen
2018-11-15 23:07 ` Thor Thayer
2018-11-17 4:38 ` David Miller
2018-11-17 15:29 ` Westergreen, Dalon
2018-11-15 0:50 ` [PATCH net-next 2/8] net: eth: altera: set rx and tx ring size before init_dma call Dalon Westergreen
2018-11-15 23:08 ` Thor Thayer
2018-11-15 0:50 ` [PATCH net-next 3/8] net: eth: altera: tse: fix altera_dmaops declaration Dalon Westergreen
2018-11-15 23:10 ` Thor Thayer [this message]
2018-11-15 0:50 ` [PATCH net-next 4/8] net: eth: altera: tse: add optional function to start tx dma Dalon Westergreen
2018-11-15 23:12 ` Thor Thayer
2018-11-15 0:50 ` [PATCH net-next 5/8] net: eth: altera: tse: Move common functions to altera_utils Dalon Westergreen
2018-11-15 23:14 ` Thor Thayer
2018-11-15 0:50 ` [PATCH net-next 6/8] net: eth: altera: tse: add support for ptp and timestamping Dalon Westergreen
2018-11-15 3:24 ` Richard Cochran
[not found] ` <729c71a95091f0902396be8b6c73409cd1e8ae9d.camel@gmail.com>
2018-11-16 2:14 ` Richard Cochran
2018-11-16 13:33 ` Dalon Westergreen
2018-11-16 14:48 ` Dalon Westergreen
2018-11-16 18:37 ` Richard Cochran
2018-11-15 0:50 ` [PATCH net-next 7/8] net: eth: altera: tse: add msgdma prefetcher Dalon Westergreen
2018-11-16 15:20 ` Thor Thayer
2018-11-28 0:26 ` Dalon Westergreen
2018-11-15 0:50 ` [PATCH net-next 8/8] net: eth: altera: tse: update devicetree bindings documentation Dalon Westergreen
2018-11-15 23:49 ` Thor Thayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b5267bb-ca63-6dc3-39c6-e06cf4ad1daf@linux.intel.com \
--to=thor.thayer@linux.intel.com \
--cc=dalon.westergreen@intel.com \
--cc=dinguyen@kernel.org \
--cc=dwesterg@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).