From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thor Thayer Subject: Re: [PATCH net-next 3/8] net: eth: altera: tse: fix altera_dmaops declaration Date: Thu, 15 Nov 2018 17:10:20 -0600 Message-ID: <3b5267bb-ca63-6dc3-39c6-e06cf4ad1daf@linux.intel.com> References: <20181115005047.28464-1-dwesterg@gmail.com> <20181115005047.28464-4-dwesterg@gmail.com> Reply-To: thor.thayer@linux.intel.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Dalon Westergreen To: Dalon Westergreen , netdev@vger.kernel.org, dinguyen@kernel.org Return-path: Received: from mga07.intel.com ([134.134.136.100]:64398 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbeKPJRn (ORCPT ); Fri, 16 Nov 2018 04:17:43 -0500 In-Reply-To: <20181115005047.28464-4-dwesterg@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/14/18 6:50 PM, Dalon Westergreen wrote: > From: Dalon Westergreen > > The declaration of struct altera_dmaops does not have > identifier names. Add identifier names to confrom with > required coding styles. > > Signed-off-by: Dalon Westergreen > --- > drivers/net/ethernet/altera/altera_tse.h | 30 +++++++++++++----------- > 1 file changed, 16 insertions(+), 14 deletions(-) > > diff --git a/drivers/net/ethernet/altera/altera_tse.h b/drivers/net/ethernet/altera/altera_tse.h > index e2feee87180a..d5b97e02e6d6 100644 > --- a/drivers/net/ethernet/altera/altera_tse.h > +++ b/drivers/net/ethernet/altera/altera_tse.h > @@ -396,20 +396,22 @@ struct altera_tse_private; > struct altera_dmaops { > int altera_dtype; > int dmamask; > - void (*reset_dma)(struct altera_tse_private *); > - void (*enable_txirq)(struct altera_tse_private *); > - void (*enable_rxirq)(struct altera_tse_private *); > - void (*disable_txirq)(struct altera_tse_private *); > - void (*disable_rxirq)(struct altera_tse_private *); > - void (*clear_txirq)(struct altera_tse_private *); > - void (*clear_rxirq)(struct altera_tse_private *); > - int (*tx_buffer)(struct altera_tse_private *, struct tse_buffer *); > - u32 (*tx_completions)(struct altera_tse_private *); > - void (*add_rx_desc)(struct altera_tse_private *, struct tse_buffer *); > - u32 (*get_rx_status)(struct altera_tse_private *); > - int (*init_dma)(struct altera_tse_private *); > - void (*uninit_dma)(struct altera_tse_private *); > - void (*start_rxdma)(struct altera_tse_private *); > + void (*reset_dma)(struct altera_tse_private *priv); > + void (*enable_txirq)(struct altera_tse_private *priv); > + void (*enable_rxirq)(struct altera_tse_private *priv); > + void (*disable_txirq)(struct altera_tse_private *priv); > + void (*disable_rxirq)(struct altera_tse_private *priv); > + void (*clear_txirq)(struct altera_tse_private *priv); > + void (*clear_rxirq)(struct altera_tse_private *priv); > + int (*tx_buffer)(struct altera_tse_private *priv, > + struct tse_buffer *buffer); > + u32 (*tx_completions)(struct altera_tse_private *priv); > + void (*add_rx_desc)(struct altera_tse_private *priv, > + struct tse_buffer *buffer); > + u32 (*get_rx_status)(struct altera_tse_private *priv); > + int (*init_dma)(struct altera_tse_private *priv); > + void (*uninit_dma)(struct altera_tse_private *priv); > + void (*start_rxdma)(struct altera_tse_private *priv); > }; > > /* This structure is private to each device. > Acked-by: Thor Thayer